Issue 7828084: Refactor ScopedJavaRef

Issue 7828084: Refactor ScopedJavaRef (Closed)

Created:
9 years, 3 months ago by joth

Modified:
9 years, 3 months ago

Reviewers:
bulach, Steve Block, brettw

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Refactor ScopedJavaRef - introduces JavaRef<> base class to allow passing refs without knowledge of their scope - makes the ScopedJavaLocalRef and ScopedJavaGlobalRef consistent, in name, in methods available, and in conversions allowed. Also updates some other minor base API changes whilst I'm in those files. BUG= TEST=doesn't break build... Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100383

Patch Set 1 #

Patch Set 2 : ' #

Patch Set 3 : disallow copy ctor on JavaRef #

Patch Set 4 : bulach comments #

Patch Set 5 : operator= docs #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+413 lines, -160 lines)			Patch
M	base/android/jni_android.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	base/android/jni_android.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	base/android/jni_array.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	base/android/jni_array.cc	View	1 2 3	3 chunks	+26 lines, -18 lines	1 comment	Download
M	base/android/jni_string.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	base/android/jni_string.cc	View		1 chunk	+9 lines, -4 lines	0 comments	Download
M	base/android/path_utils.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
D	base/android/scoped_java_global_reference.h	View		1 chunk	+0 lines, -63 lines	0 comments	Download
A	base/android/scoped_java_ref.h	View	1 2 3 4	1 chunk	+175 lines, -0 lines	0 comments	Download
A	base/android/scoped_java_ref.cc	View	1 2 3	1 chunk	+47 lines, -0 lines	0 comments	Download
A	base/android/scoped_java_ref_unittest.cc	View	1 2	1 chunk	+114 lines, -0 lines	0 comments	Download
D	base/android/scoped_java_reference.h	View		1 chunk	+0 lines, -69 lines	0 comments	Download
M	base/base.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	base/base.gypi	View		1 chunk	+10 lines, -2 lines	0 comments	Download
M	build/common.gypi	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

LGTM (but need an owners approval) thanks for addressing the offline comments, the latest patch ...

9 years, 3 months ago (2011-09-05 20:56:06 UTC) #2

joth

+brettw for owners approval. Landing some edits made elsewhere...

9 years, 3 months ago (2011-09-05 21:26:41 UTC) #3

brettw

LGTM rubberstamp. http://codereview.chromium.org/7828084/diff/3020/base/android/jni_array.cc File base/android/jni_array.cc (right): http://codereview.chromium.org/7828084/diff/3020/base/android/jni_array.cc#newcode39 base/android/jni_array.cc:39: reinterpret_cast<const uint8*>(v[i].data()), v[i].length())); Can you fix the ...

9 years, 3 months ago (2011-09-06 18:12:27 UTC) #4

LGTM

Expand Messages | Collapse Messages