Issue 7828080: Fix and test use of property descriptor objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7828080: Fix and test use of property descriptor objects. (Closed)

Created:
9 years, 3 months ago by rossberg

Modified:
9 years, 3 months ago

Reviewers:
Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix and test use of property descriptor objects. R=kmillikin@chromium.org BUG=v8:1543 TEST= Committed: http://code.google.com/p/v8/source/detail?r=9364

Patch Set 2 : Addressed Kevin's comments. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -5 lines)			Patch
M	src/bootstrapper.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/contexts.h	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+23 lines, -2 lines	0 comments	Download
M	test/mjsunit/harmony/proxies.js	View		3 chunks	+57 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

LGTM. http://codereview.chromium.org/7828080/diff/1/src/bootstrapper.cc File src/bootstrapper.cc (right): http://codereview.chromium.org/7828080/diff/1/src/bootstrapper.cc#newcode1324 src/bootstrapper.cc:1324: INSTALL_NATIVE(JSFunction, "ToPropertyDescriptor", to_property_descriptor); Do you need this one? ...

9 years, 3 months ago (2011-09-05 13:48:59 UTC) #2

rossberg

9 years, 3 months ago (2011-09-05 14:07:49 UTC) #3

http://codereview.chromium.org/7828080/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):

http://codereview.chromium.org/7828080/diff/1/src/bootstrapper.cc#newcode1324
src/bootstrapper.cc:1324: INSTALL_NATIVE(JSFunction, "ToPropertyDescriptor",
to_property_descriptor);
On 2011/09/05 13:48:59, Kevin Millikin wrote:
> Do you need this one?

No, removed.

http://codereview.chromium.org/7828080/diff/1/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7828080/diff/1/src/objects.cc#newcode2313
src/objects.cc:2313: Handle<String> enum_name =
isolate->factory()->LookupAsciiSymbol("enumerable");
On 2011/09/05 13:48:59, Kevin Millikin wrote:
> It looks like there are a couple of long lines.  Check presubmit before
> committing.

Done.

Expand Messages | Collapse Messages

Issue 7828080: Fix and test use of property descriptor objects. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed Kevin's comments. #

Messages