Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 7828055: Move sync test code out of chrome/test (Closed)

Created:
9 years, 3 months ago by Paweł Hajdan Jr.
Modified:
9 years, 3 months ago
Reviewers:
Raghu Simha, sky, akalin
CC:
chromium-reviews, ncarter (slow), idana, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, tim (not reviewing)
Visibility:
Public.

Description

Move sync test code out of chrome/test BUG=90905 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99464

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -14207 lines) Patch
M chrome/browser/sync/abstract_profile_sync_service_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/backend_migrator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/apply_updates_command_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/build_commit_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/cleanup_disabled_types_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/clear_data_command_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/download_updates_command_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/process_commit_response_command_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/sync_scheduler_whitebox_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_proto_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/engine/verify_updates_command_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_registrar_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/internal_api/syncapi_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/js/DEPS View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/js/js_sync_manager_observer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/ordered_commit_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/status_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sessions/sync_session_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/syncable_id_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/syncable_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/syncable_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/engine/mock_connection_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/engine/mock_connection_manager.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/engine/mock_gaia_authenticator.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/engine/mock_gaia_authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M + chrome/browser/sync/test/engine/mock_gaia_authenticator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M + chrome/browser/sync/test/engine/proto_extension_validator.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/engine/syncer_command_test.h View 3 chunks +5 lines, -5 lines 0 comments Download
M + chrome/browser/sync/test/engine/test_directory_setter_upper.h View 3 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/engine/test_directory_setter_upper.cc View 1 chunk +1 line, -1 line 0 comments Download
M + chrome/browser/sync/test/engine/test_id_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/engine/test_syncable_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/engine/test_syncable_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M + chrome/browser/sync/test/engine/test_user_share.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/engine/test_user_share.cc View 1 chunk +1 line, -1 line 0 comments Download
M + chrome/browser/sync/test/live_sync/PRESUBMIT.py View 1 chunk +1 line, -1 line 0 comments Download
M + chrome/browser/sync/test/live_sync/apps_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/apps_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/autofill_helper.h View 3 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/autofill_helper.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/bookmarks_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/bookmarks_helper.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/extensions_helper.h View 3 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/extensions_helper.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/live_sync_test.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/live_sync_test.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/many_client_bookmarks_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/many_client_passwords_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/many_client_preferences_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/migration_errors_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/multiple_client_bookmarks_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/multiple_client_passwords_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/multiple_client_preferences_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/multiple_client_sessions_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/multiple_client_typed_urls_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/passwords_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/passwords_helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/performance/autofill_sync_perf_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/performance/bookmarks_sync_perf_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/performance/extensions_sync_perf_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/performance/passwords_sync_perf_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/performance/sessions_sync_perf_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/performance/sync_timing_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/performance/sync_timing_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M + chrome/browser/sync/test/live_sync/performance/typed_urls_sync_perf_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/preferences_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/preferences_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/sessions_helper.h View 3 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/sessions_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/single_client_apps_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/single_client_bookmarks_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/single_client_extensions_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/single_client_passwords_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/single_client_preferences_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/single_client_sessions_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/single_client_themes_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/single_client_typed_urls_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/sync_datatype_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/sync_datatype_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/sync_errors_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/sync_extension_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/sync_extension_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/themes_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/themes_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_apps_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_autofill_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_bookmarks_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_extensions_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_passwords_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_preferences_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_sessions_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_themes_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/two_client_typed_urls_sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/typed_urls_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/live_sync/typed_urls_helper.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/null_directory_change_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/null_directory_change_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M + chrome/browser/sync/test/sessions/test_scoped_session_event_listener.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/test_http_bridge_factory.h View 2 chunks +3 lines, -3 lines 0 comments Download
M + chrome/browser/sync/test/test_http_bridge_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test_profile_sync_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/test_profile_sync_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 7 chunks +95 lines, -95 lines 0 comments Download
D chrome/test/live_sync/PRESUBMIT.py View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/test/live_sync/apps_helper.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/live_sync/apps_helper.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/test/live_sync/autofill_helper.h View 1 chunk +0 lines, -97 lines 0 comments Download
D chrome/test/live_sync/autofill_helper.cc View 1 chunk +0 lines, -298 lines 0 comments Download
D chrome/test/live_sync/bookmarks_helper.h View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/test/live_sync/bookmarks_helper.cc View 1 chunk +0 lines, -593 lines 0 comments Download
D chrome/test/live_sync/extensions_helper.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/test/live_sync/extensions_helper.cc View 1 chunk +0 lines, -125 lines 0 comments Download
D chrome/test/live_sync/live_sync_test.h View 1 chunk +0 lines, -317 lines 0 comments Download
D chrome/test/live_sync/live_sync_test.cc View 1 chunk +0 lines, -632 lines 0 comments Download
D chrome/test/live_sync/many_client_bookmarks_sync_test.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/test/live_sync/many_client_passwords_sync_test.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/test/live_sync/many_client_preferences_sync_test.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/live_sync/migration_errors_test.cc View 1 chunk +0 lines, -453 lines 0 comments Download
D chrome/test/live_sync/multiple_client_bookmarks_sync_test.cc View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/test/live_sync/multiple_client_passwords_sync_test.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/test/live_sync/multiple_client_preferences_sync_test.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/test/live_sync/multiple_client_sessions_sync_test.cc View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/test/live_sync/multiple_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/test/live_sync/passwords_helper.h View 1 chunk +0 lines, -81 lines 0 comments Download
D chrome/test/live_sync/passwords_helper.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/test/live_sync/performance/autofill_sync_perf_test.cc View 1 chunk +0 lines, -198 lines 0 comments Download
D chrome/test/live_sync/performance/bookmarks_sync_perf_test.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/test/live_sync/performance/extensions_sync_perf_test.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/test/live_sync/performance/passwords_sync_perf_test.cc View 1 chunk +0 lines, -95 lines 0 comments Download
D chrome/test/live_sync/performance/sessions_sync_perf_test.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/test/live_sync/performance/sync_timing_helper.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/test/live_sync/performance/sync_timing_helper.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/test/live_sync/performance/typed_urls_sync_perf_test.cc View 1 chunk +0 lines, -102 lines 0 comments Download
D chrome/test/live_sync/preferences_helper.h View 1 chunk +0 lines, -100 lines 0 comments Download
D chrome/test/live_sync/preferences_helper.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D chrome/test/live_sync/sessions_helper.h View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/test/live_sync/sessions_helper.cc View 1 chunk +0 lines, -293 lines 0 comments Download
D chrome/test/live_sync/single_client_apps_sync_test.cc View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/test/live_sync/single_client_bookmarks_sync_test.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D chrome/test/live_sync/single_client_extensions_sync_test.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/test/live_sync/single_client_passwords_sync_test.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/test/live_sync/single_client_preferences_sync_test.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/live_sync/single_client_sessions_sync_test.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/live_sync/single_client_themes_sync_test.cc View 1 chunk +0 lines, -99 lines 0 comments Download
D chrome/test/live_sync/single_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D chrome/test/live_sync/sync_datatype_helper.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/test/live_sync/sync_datatype_helper.cc View 1 chunk +0 lines, -29 lines 0 comments Download
D chrome/test/live_sync/sync_errors_test.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/test/live_sync/sync_extension_helper.h View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/test/live_sync/sync_extension_helper.cc View 1 chunk +0 lines, -361 lines 0 comments Download
D chrome/test/live_sync/sync_integration_test.py View 1 chunk +0 lines, -404 lines 0 comments Download
D chrome/test/live_sync/themes_helper.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/test/live_sync/themes_helper.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/test/live_sync/two_client_apps_sync_test.cc View 1 chunk +0 lines, -280 lines 0 comments Download
D chrome/test/live_sync/two_client_autofill_sync_test.cc View 1 chunk +0 lines, -409 lines 0 comments Download
D chrome/test/live_sync/two_client_bookmarks_sync_test.cc View 1 chunk +0 lines, -1757 lines 0 comments Download
D chrome/test/live_sync/two_client_extensions_sync_test.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D chrome/test/live_sync/two_client_passwords_sync_test.cc View 1 chunk +0 lines, -323 lines 0 comments Download
D chrome/test/live_sync/two_client_preferences_sync_test.cc View 1 chunk +0 lines, -669 lines 0 comments Download
D chrome/test/live_sync/two_client_sessions_sync_test.cc View 1 chunk +0 lines, -353 lines 0 comments Download
D chrome/test/live_sync/two_client_themes_sync_test.cc View 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/test/live_sync/two_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -178 lines 0 comments Download
D chrome/test/live_sync/typed_urls_helper.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/test/live_sync/typed_urls_helper.cc View 1 chunk +0 lines, -184 lines 0 comments Download
D chrome/test/sync/engine/mock_connection_manager.h View 1 chunk +0 lines, -364 lines 0 comments Download
D chrome/test/sync/engine/mock_connection_manager.cc View 1 chunk +0 lines, -624 lines 0 comments Download
D chrome/test/sync/engine/mock_gaia_authenticator.h View 1 chunk +0 lines, -117 lines 0 comments Download
D chrome/test/sync/engine/mock_gaia_authenticator.cc View 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/test/sync/engine/mock_gaia_authenticator_unittest.cc View 1 chunk +0 lines, -158 lines 0 comments Download
D chrome/test/sync/engine/proto_extension_validator.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/test/sync/engine/syncer_command_test.h View 1 chunk +0 lines, -170 lines 0 comments Download
D chrome/test/sync/engine/test_directory_setter_upper.h View 1 chunk +0 lines, -144 lines 0 comments Download
D chrome/test/sync/engine/test_directory_setter_upper.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D chrome/test/sync/engine/test_id_factory.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/test/sync/engine/test_syncable_utils.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/test/sync/engine/test_syncable_utils.cc View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/test/sync/engine/test_user_share.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/test/sync/engine/test_user_share.cc View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/test/sync/null_directory_change_delegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/test/sync/null_directory_change_delegate.cc View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/sync/sessions/test_scoped_session_event_listener.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/test/sync/test_http_bridge_factory.h View 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/test/sync/test_http_bridge_factory.cc View 1 chunk +0 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Paweł Hajdan Jr.
9 years, 3 months ago (2011-09-02 20:14:59 UTC) #1
sky
Rubber stamp LGTM
9 years, 3 months ago (2011-09-02 20:59:02 UTC) #2
akalin
On 2011/09/02 20:59:02, sky wrote: > Rubber stamp LGTM LGTM
9 years, 3 months ago (2011-09-02 21:42:39 UTC) #3
Raghu Simha
Pawel, thanks for making this change. The directory name "live_sync" is somewhat historic, and made ...
9 years, 3 months ago (2011-09-03 18:32:32 UTC) #4
Paweł Hajdan Jr.
On 2011/09/03 18:32:32, rsimha wrote: > Pawel, thanks for making this change. > > The ...
9 years, 3 months ago (2011-09-06 17:03:02 UTC) #5
Raghu Simha
9 years, 3 months ago (2011-09-06 21:50:19 UTC) #6
On 2011/09/06 17:03:02, Paweł Hajdan Jr. wrote:
> On 2011/09/03 18:32:32, rsimha wrote:
> > Pawel, thanks for making this change.
> > 
> > The directory name "live_sync" is somewhat historic, and made sense when it
> was
> > located in chrome/test. Now that all sync tests are under browser/sync,
> > "live_sync" seems redundant, and it might make sense to rename the directory
> > "integration" (to differentiate it from the tests under "engine").
> 
> Agreed.
> 
> > I realise you've already landed this patch, so let me know if you'd like me
to
> > make this change. (Since you're reorganizing test code in a big way, I feel
it
> > makes sense to do this now.)
> 
> Feel free to move that code within chrome/browser/sync as you wish, what I
> mostly care about is moving it out of chrome/test. I'm fine either way.

Done. http://codereview.chromium.org/7841007/ sent to you for review.

Powered by Google App Engine
This is Rietveld 408576698