Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons

Issue 7828045: NaCl Proxy Test: enable ppapi_ppb_fullscreen_browser_test except for Mac. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/native_client/tests/ppapi_test_lib/nacl.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons
===================================================================
--- ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons (revision 99979)
+++ ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons (working copy)
@@ -33,7 +33,12 @@
files=env.ExtractPublishedFiles(nexe),
browser_flags=['--enable-pepper-testing'])
+# Fatal Error on Mac:
+# ERROR:render_widget_host_view_mac.mm(344)] Not implemented reached in virtual
+# void RenderWidgetHost ViewMac::InitAsFullscreen(RenderWidgetHostView *)Full
+# screen not implemented on Mac
env.AddNodeToTestSuite(node,
['chrome_browser_tests'],
'run_ppapi_ppb_fullscreen_browser_test',
- is_broken=env.PPAPIBrowserTesterIsBroken())
+ is_broken=(env.PPAPIBrowserTesterIsBroken() or
+ env.Bit('host_mac')))
« no previous file with comments | « no previous file | ppapi/native_client/tests/ppapi_test_lib/nacl.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698