Issue 7828044: [filebrowser] First step to image editor.

Issue 7828044: [filebrowser] First step to image editor. (Closed)

Created:
9 years, 3 months ago by dgozman

Modified:
9 years, 3 months ago

Reviewers:
rginda, commit-bot: I haz the power, Vladislav Kaznacheev, zel

CC:
chromium-reviews, Erik does not do reviews, achuith+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[filebrowser] First step to gallery (image editor). No sharing, nice UI and animations. No save reminders and feedback. Most effects have preview on the whole image and so are little slow. BUG=chromium-os:19534 TEST=Try out 'Gallery' action for images. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100296

Patch Set 1 #

Total comments: 10

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : Removed commented code. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+532 lines, -57 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_file_browser_private_api.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/resources/file_manager/js/file_manager.js	View	1 2 3	6 chunks	+20 lines, -30 lines	0 comments	Download
A	chrome/browser/resources/file_manager/js/image_editor/gallery.css	View	1 2	1 chunk	+134 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/js/image_editor/gallery.html	View	1 2	1 chunk	+33 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/js/image_editor/gallery.js	View	1 2 3	1 chunk	+295 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_buffer.js	View	1 2	4 chunks	+10 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_editor.css	View	1 2	3 chunks	+8 lines, -6 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_editor.html	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/image_editor/image_editor.js	View	1 2	4 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/resources/file_manager/js/mock_chrome.js	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/manifest.json	View	1 2	2 chunks	+13 lines, -9 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

zel

http://codereview.chromium.org/7828044/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/7828044/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode1684 chrome/browser/resources/file_manager/js/file_manager.js:1684: } else if (task_parts[1] == 'gallery') { how's gallery ...

9 years, 3 months ago (2011-09-02 17:11:58 UTC) #2

dgozman

Ribbon control introduced (in gallery.js). Some minor tweaks. http://codereview.chromium.org/7828044/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): http://codereview.chromium.org/7828044/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode1684 chrome/browser/resources/file_manager/js/file_manager.js:1684: } ...

9 years, 3 months ago (2011-09-06 14:18:47 UTC) #3

Change committed as 100296

Expand Messages | Collapse Messages