build/asan.saves - Issue 7828043: If the 'asan' GYP variable is set to 1 on Mac, do not strip the __asan_init symbol from the binar...

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/asan.saves

Issue 7828043: If the 'asan' GYP variable is set to 1 on Mac, do not strip the __asan_init symbol from the binar... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 # Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 # This file lists symbols that should not be stripped from the binaries built
	Mark Mentovai 2011/09/02 13:37:21 This is not in a mac directory, so the comment sho This is not in a mac directory, so the comment should indicate that this file is Mac-specific. That way, someone who just finds the file will be able to tell exactly what it’s for. Alexander Potapenko 2011/09/02 14:33:42 Actually chrome/app/ is not a mac directory, but y Show quoted text On 2011/09/02 13:37:21, Mark Mentovai wrote: > This is not in a mac directory, so the comment should indicate that this file is > Mac-specific. That way, someone who just finds the file will be able to tell > exactly what it’s for. Actually chrome/app/ is not a mac directory, but you're right. Done Mark Mentovai 2011/09/02 14:38:14 Alexander Potapenko wrote: Alexander Potapenko wrote: Show quoted text > Actually chrome/app/ is not a mac directory, but you're right. Right, the point was that since the existing file in chrome/app isn’t in a Mac-specific directory, it ha a comment (already) stating that it’s Mac-specific. I only said “mac directory” because such a comment would probably be irrelevant if the file was already in a mac directory. _com_google_glider 2011/09/02 14:48:53 Actually chrome/app/ is not a mac directory either Actually chrome/app/ is not a mac directory either, but, yes, you're right. Done.
	6 # with AddressSanitizer

	7 # (http://dev.chromium.org/developers/testing/addresssanitizer).

	8

	9 ___asan_init

OLD	NEW

« no previous file with comments | « no previous file | build/common.gypi » ('j') | build/common.gypi » ('J')