Issue 7828038: Workaround windows classic theme caption rendering artifacts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7828038: Workaround windows classic theme caption rendering artifacts. (Closed)

Created:
9 years, 3 months ago by msw

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, Ben Goodger (Google)

CC:
chromium-reviews, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Workaround windows classic theme rendering artifacts. Wrap DefWindowProc for WM_NCLBUTTONDOWN with ScopedRedrawLock. Update the saved window style to handle max/restore, etc. BUG=89820 TEST=No windows classic theme caption button rendering artifacts when clicking the title bar area. No related mouse event, window re-sizing/style regressions. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99498

Patch Set 1 : Implement alternate WM_SETREDRAW lock on WM_NCLBUTTONDOWN. #

Patch Set 2 : Use a ScopedRedrawLock and update |saved_window_style_| on WM_NCLBUTTONDOWN. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -19 lines)			Patch
	M	views/widget/native_widget_win.cc	View	1	2 chunks	+15 lines, -19 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

Assuming window dragging, sizing etc all still work, LGTM.

9 years, 3 months ago (2011-09-02 21:34:11 UTC) #2

Change committed as 99498

Expand Messages | Collapse Messages