Issue 7828003: Cleanup of messages.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7828003: Cleanup of messages.js. (Closed)

Created:
9 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 3 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Cleanup of messages.js. Lock down some otherwise modifiable objects that don't need it. Committed: http://code.google.com/p/v8/source/detail?r=9089

Patch Set 2 : Addres review comments #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+223 lines, -218 lines)			Patch
M	src/math.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/messages.js	View	1	7 chunks	+221 lines, -217 lines	0 comments	Download
M	src/runtime.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Rico

LGTM http://codereview.chromium.org/7828003/diff/1/src/messages.js File src/messages.js (right): http://codereview.chromium.org/7828003/diff/1/src/messages.js#newcode49 src/messages.js:49: const kMessages = 0; Please add comment that ...

9 years, 3 months ago (2011-09-01 07:28:55 UTC) #2

Lasse Reichstein

9 years, 3 months ago (2011-09-01 07:38:18 UTC) #3

http://codereview.chromium.org/7828003/diff/1/src/messages.js
File src/messages.js (right):

http://codereview.chromium.org/7828003/diff/1/src/messages.js#newcode49
src/messages.js:49: const kMessages = 0;
Comment added.

Expand Messages | Collapse Messages

Issue 7828003: Cleanup of messages.js. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addres review comments #

Messages