Introduce net::HttpServerPropertiesManager to manage server-specific properties.

net/http/http_server_properties.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_HTTP_HTTP_SERVER_PROPERTIES_H_
+#define NET_HTTP_HTTP_SERVER_PROPERTIES_H_
+#pragma once
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/hash_tables.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/string_piece.h"
+#include "base/values.h"
+#include "net/base/host_port_pair.h"
+#include "net/base/net_export.h"
+
+namespace base {
+class ListValue;
+}
+
+namespace net {
+
+// The interface for retrieving the HTTP server properties.
+class NET_EXPORT HttpServerProperties {
+ public:
+  HttpServerProperties();
+
+  // Returns true if |server| supports SPDY.
+  virtual bool SupportsSpdy(const HostPortPair& server);

[willchan no longer on Chromium, 2011/10/02 18:33:13]

Member function should be const.

[ramant (doing other things), 2011/10/04 05:23:24]

Done.

+
+  // Add |server| into the persisitent store. Should only be called from IO

[willchan no longer on Chromium, 2011/10/02 18:33:13]

persistent

[ramant (doing other things), 2011/10/04 05:23:24]

Done.

+  // thread.
+  virtual void SetSupportsSpdy(const HostPortPair& server,

[willchan no longer on Chromium, 2011/10/02 18:33:13]

Can you make these virtuals be pure virtuals? Also make sure to use the OVERRIDE
macro.

Take all the implementation details (the non-public virtuals) and move them out
into a HttpServerPropertiesImpl class. Turn the protected member functions into
public member functions. Then have HttpServerPropertiesManager include the
HttpServerPropertiesImpl class as a member variable. This is composition. See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Inheri...
which says composition is often more appropriate than inheritance.

[ramant (doing other things), 2011/10/04 05:23:24]

Done.

+                               bool support_spdy);
+
+ protected:
+  typedef std::vector<std::string> StringVector;
+
+  virtual ~HttpServerProperties();
+
+  // Initializes |spdy_servers_table_| with the servers (host/port) from
+  // |spdy_servers| that either support SPDY or not.
+  void Initialize(StringVector* spdy_servers, bool support_spdy);
+
+  // Get the list of servers (host/port) that support SPDY.
+  void GetSpdyServerList(base::ListValue* spdy_server_list);
+
+ private:
+  // Flattens the |host_port_pair| into the |spdy_server| string.
+  void GetFlattenedSpdyServer(const net::HostPortPair& host_port_pair,

[willchan no longer on Chromium, 2011/10/02 18:33:13]

Does this need to be in the .h file? It seems like this could be a non-member
function placed in an anonymous namespace in the .cc file. See
https://plus.google.com/109863453537346300676/posts/jBkBP18DKCD (internal only)
for an explanation ('I feel like people often forget Effective C++'s Item 23:
"Prefer non-member non-friend functions to member functions." C++ doesn't mean
everything needs to be a member function.').

[ramant (doing other things), 2011/10/04 05:23:24]

Done.

+                              std::string& spdy_server);

[willchan no longer on Chromium, 2011/10/02 18:33:13]

http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Refere....
spdy_server should not be a non-const reference argument. The common ways to
accomplish this are to use an pointer output argument or return the value. I'd
return the value. Don't worry about the cost of a copy, because all modern
compilers will use (http://efnetcpp.org/wiki/Return_value_optimization) to
optimize it away.

[ramant (doing other things), 2011/10/04 05:23:24]

Done.

+
+  // |spdy_servers_table_| has flattened representation of servers (host/port
+  // pair) that either support or not support SPDY protocol.
+  typedef base::hash_map<std::string, bool> SpdyServerHostPortTable;

[willchan no longer on Chromium, 2011/10/02 18:33:13]

types go first in the section

[ramant (doing other things), 2011/10/04 05:23:24]

Done.

+  SpdyServerHostPortTable spdy_servers_table_;
+};

[willchan no longer on Chromium, 2011/10/02 18:33:13]

DISALLOW_COPY_AND_ASSIGN

[ramant (doing other things), 2011/10/04 05:23:24]

Done.

+
+}  // namespace net
+
+#endif  // NET_HTTP_HTTP_SERVER_PROPERTIES_H_