Changed mac and win Official Chrome build to drop default app CRXs in the build/installer output.

chrome/chrome_dll.gypi

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'target_defaults': {
     'variables': {
       'chrome_dll_target': 0,
     },
     'target_conditions': [
       ['chrome_dll_target==1', {
@@ skipping 145 matching lines @@
                       'ProgramDatabaseFile': '$(OutDir)\\initial\\chrome_dll.pdb',
                       'OutputFile': '$(OutDir)\\initial\\chrome.dll',
                     }], ['incremental_chrome_dll==1', {
                       'OutputFile': '$(OutDir)\\initial\\chrome.dll',
                       'UseLibraryDependencyInputs': "true",
                     }],
                   ],
                 },
               },
               'conditions': [
+                ['buildtype=="Official" and branding=="Chrome"', {
+                  'copies': [
+                    {
+                      'destination': '<(PRODUCT_DIR)/default_apps',

[Mark Mentovai, 2011/09/01 20:53:38]

Why do you need to copy things to <(PRODUCT_DIR)/default_apps? I don’t think you
ever reference anything in this location.

[SteveT, 2011/09/01 21:19:57]

This is the expected location for win, according to 7811020. I'll add a comment
here for Robert about how these are pulled in by chrome.release, and also
explicitly mention that this is for Windows.

+                      'files': [
+                        'browser/resources/default_apps/gmail.crx',
+                        'browser/resources/default_apps/youtube.crx',
+                      ],
+                    },
+                  ],
+                }],
                 ['incremental_chrome_dll==1 and optimize_with_syzygy==0', {
                   # Linking to a different directory and then hardlinking back
                   # to OutDir is a workaround to avoid having the .ilk for
                   # chrome.exe and chrome.dll conflicting. See crbug.com/92528
                   # for more information. Done on the dll instead of the exe so
                   # that people launching from VS don't need to modify
                   # $(TargetPath) for the exe.
                   'msvs_postbuild': 'tools\\build\\win\\hardlink_failsafe.bat $(OutDir)\\initial\\chrome.dll $(OutDir)\\chrome.dll'
                 }]
               ]
@@ skipping 407 matching lines @@
                   'conditions': [
                     ['debug_devtools!=0', {
                       'files': [
                          '<(PRODUCT_DIR)/resources/inspector',
                       ],
                     }],
                   ],
                 },
               ],
               'conditions': [
+                ['buildtype=="Official" and branding=="Chrome"', {
+                  'copies': [
+                    {
+                      'destination':
+                          '<(PRODUCT_DIR)/$(CONTENTS_FOLDER_PATH)/Default Apps',

[Mark Mentovai, 2011/09/01 20:53:38]

I commented in 7811020 about this. I don’t think the path you’re using there is
correct.

[SteveT, 2011/09/01 21:19:57]

Discussed with Cait. I thought they had implemented that bit with the correct
location, but that's not the case yet. They'll address that before committing.

+                      'files': [
+                        'browser/resources/default_apps/gmail.crx',
+                        'browser/resources/default_apps/youtube.crx',
+                      ],
+                    },
+                  ],
+                }],
                 ['mac_breakpad==1', {
                   'variables': {
                     # A real .dSYM is needed for dump_syms to operate on.
                     'mac_real_dsym': 1,
                   },
                   'sources': [
                     'app/breakpad_mac.mm',
                     'app/breakpad_mac.h',
                   ],
                   'dependencies': [
@@ skipping 146 matching lines @@
                   'LinkIncremental': '<(msvs_debug_link_nonincremental)',
                 },
               },
             },
           },
         },  # target chrome_dll
       ],
     }],
   ],
 }