Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 7827004: Use gtest's own implementation of tr1::tuple on Android. (Closed)

Created:
9 years, 3 months ago by HaoZheng
Modified:
9 years, 3 months ago
CC:
chromium-reviews, andreip1, John Grabowski
Visibility:
Public.

Description

Use gtest's own implementation of tr1::tuple on Android. Android's libstdc++ doesn't include tr1:: tuple so we must use gtest's instead. This will allow us build gtest/gmock on Android. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99636

Patch Set 1 #

Total comments: 1

Patch Set 2 : feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M testing/gtest.gyp View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Beverloo
Looks good, this will allow us to build gtest/gmock. Evan, could you verify the change? ...
9 years, 3 months ago (2011-09-01 12:34:08 UTC) #1
Evan Martin
LGTM, but can you make the review description say why? It's self-evident from the patch ...
9 years, 3 months ago (2011-09-01 14:50:00 UTC) #2
HaoZheng
9 years, 3 months ago (2011-09-02 02:59:40 UTC) #3
Evan Martin
9 years, 3 months ago (2011-09-02 03:39:21 UTC) #4
still LGTM, but it'd be nice to say *why* this work

Powered by Google App Engine
This is Rietveld 408576698