printing/print_job_constants.h - Issue 7826040: PrintPreview: Fixed RICOH MP C3501 color print job issues.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: printing/print_job_constants.h

Issue 7826040: PrintPreview: Fixed RICOH MP C3501 color print job issues. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/webui/print_preview_handler.cc ('K') | « chrome/renderer/print_web_view_helper_browsertest.cc ('k') | printing/printing_context_mac.h » ('j') | printing/printing_context_mac.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef PRINTING_PRINT_JOB_CONSTANTS_H_	5 #ifndef PRINTING_PRINT_JOB_CONSTANTS_H_

6 #define PRINTING_PRINT_JOB_CONSTANTS_H_	6 #define PRINTING_PRINT_JOB_CONSTANTS_H_

7	7

8 #include "printing/printing_export.h"	8 #include "printing/printing_export.h"

9	9

10 namespace printing {	10 namespace printing {

(...skipping 49 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
60 CENTER,	60 CENTER,

61 RIGHT	61 RIGHT

62 };	62 };

63	63

64 // Specifies the vertical alignment of the Headers and Footers.	64 // Specifies the vertical alignment of the Headers and Footers.

65 enum VerticalHeaderFooterPosition {	65 enum VerticalHeaderFooterPosition {

66 TOP,	66 TOP,

67 BOTTOM	67 BOTTOM

68 };	68 };

69	69

	70 // Print job color mode values.

	71 enum ColorMode {

	72 CMYK,
	vandebo (ex-Chrome) 2011/09/02 22:38:18 Is there a reason for this enum ordering? Putting Is there a reason for this enum ordering? Putting CMYK first seems odd if not. kmadhusu 2011/09/04 01:52:51 On Win, DMCOLOR_COLOR is 2 and DMCOLOR_MONOCHROME Show quoted text On 2011/09/02 22:38:18, vandebo wrote: > Is there a reason for this enum ordering? Putting CMYK first seems odd if not. On Win, DMCOLOR_COLOR is 2 and DMCOLOR_MONOCHROME is 1. I thought I can try to use the same value. GRAY = 1 & COLOR = 2 Fixed this by setting a default value for GRAY.
	73 GRAY,

	74 COLOR,

	75 };

	76

70 } // namespace printing	77 } // namespace printing

71	78

72 #endif // PRINTING_PRINT_JOB_CONSTANTS_H_	79 #endif // PRINTING_PRINT_JOB_CONSTANTS_H_

OLD	NEW