PrintPreview: Fixed RICOH MP C3501 color print job issues.

chrome/browser/ui/webui/print_preview_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview_handler.h"
 
 #include <string>
 
 #include "base/base64.h"
 #if !defined(OS_CHROMEOS)
@@ skipping 40 matching lines @@
 #include <cups/ppd.h>
 
 #include "base/file_util.h"
 #endif
 
 namespace {
 
 const char kDisableColorOption[] = "disableColorOption";
 const char kSetColorAsDefault[] = "setColorAsDefault";
 const char kSetDuplexAsDefault[] = "setDuplexAsDefault";
+const char kPrinterColorSpace[] = "printerColorSpace";
 
 #if defined(USE_CUPS)
 const char kColorDevice[] = "ColorDevice";
+const char kColorModel[] = "ColorModel";
+const char kColor[] = "Color";
+const char kCMYK[] = "CMYK";
 const char kDuplex[] = "Duplex";
 const char kDuplexNone[] = "None";
 #elif defined(OS_WIN)
 const char kPskColor[] = "psk:Color";
 const char kPskDuplexFeature[] = "psk:JobDuplexAllDocumentsContiguously";
 const char kPskTwoSided[] = "psk:TwoSided";
 #endif
 
 enum UserActionBuckets {
   PRINT_TO_PRINTER,
@@ skipping 82 matching lines @@
     ReportPrintSettingHistogram(landscape ? LANDSCAPE : PORTRAIT);
 
   bool collate;
   if (settings.GetBoolean(printing::kSettingCollate, &collate) && collate)
     ReportPrintSettingHistogram(COLLATE);
 
   int duplex_mode;
   if (settings.GetInteger(printing::kSettingDuplexMode, &duplex_mode))
     ReportPrintSettingHistogram(duplex_mode ? DUPLEX : SIMPLEX);
 
-  bool is_color;
-  if (settings.GetBoolean(printing::kSettingColor, &is_color))
-    ReportPrintSettingHistogram(is_color ? COLOR : BLACK_AND_WHITE);
+  int color_mode;
+  if (settings.GetInteger(printing::kSettingColor, &color_mode)) {
+    ReportPrintSettingHistogram(color_mode == printing::GRAY ? BLACK_AND_WHITE :
+                                                               COLOR);
+  }
 }
 
 printing::BackgroundPrintingManager* GetBackgroundPrintingManager() {
   return g_browser_process->background_printing_manager();
 }
 
 }  // namespace
 
 class PrintSystemTaskProxy
     : public base::RefCountedThreadSafe<PrintSystemTaskProxy,
@@ skipping 88 matching lines @@
       handler_->SetupPrinterList(*printers);
     }
     delete printers;
   }
 
   void GetPrinterCapabilities(const std::string& printer_name) {
     VLOG(1) << "Get printer capabilities start for " << printer_name;
     printing::PrinterCapsAndDefaults printer_info;
     bool supports_color = true;
     bool set_duplex_as_default = false;
+    int printer_color_space = printing::GRAY;
     if (!print_backend_->GetPrinterCapsAndDefaults(printer_name,
                                                    &printer_info)) {
       return;
     }
 
 #if defined(USE_CUPS)
     FilePath ppd_file_path;
     if (!file_util::CreateTemporaryFile(&ppd_file_path))
       return;
 
@@ skipping 15 matching lines @@
       ppd_choice_t* ch = ppdFindMarkedChoice(ppd, kDuplex);
       if (ch == NULL) {
         ppd_option_t* option = ppdFindOption(ppd, kDuplex);
         if (option != NULL)
           ch = ppdFindChoice(option, option->defchoice);
       }
 
       if (ch != NULL && strcmp(ch->choice, kDuplexNone) != 0)
         set_duplex_as_default = true;
 
+      if (supports_color) {
+        // Identify the color space (COLOR/CMYK) for this printer.
+        ppd_option_t* color_model = ppdFindOption(ppd, kColorModel);
+        if (color_model != NULL) {
+          if (ppdFindChoice(color_model, kColor))
+            printer_color_space = printing::COLOR;
+          else if (ppdFindChoice(color_model, kCMYK))
+            printer_color_space = printing::CMYK;
+        }
+      }
+
       ppdClose(ppd);
     }
     file_util::Delete(ppd_file_path, false);
 #elif defined(OS_WIN)
     // According to XPS 1.0 spec, only color printers have psk:Color.
     // Therefore we don't need to parse the whole XML file, we just need to
     // search the string.  The spec can be found at:
     // http://msdn.microsoft.com/en-us/windows/hardware/gg463431.
     supports_color = (printer_info.printer_capabilities.find(kPskColor) !=
                       std::string::npos);
+    if (supports_color)
+      printer_color_space = printing::COLOR;

[vandebo (ex-Chrome), 2011/09/02 22:38:18]

Does this mean that the bug this is trying to solve doesn't repo on Windows?

[kmadhusu, 2011/09/04 01:52:51]

(repeating our conversation for future reference): This bug is repro on Windows.
Users need a seperate ICM to handle CMYK printers. We cannot set it in the
DEVMODE structure. 

+
     set_duplex_as_default =
         (printer_info.printer_defaults.find(kPskDuplexFeature) !=
             std::string::npos) &&
         (printer_info.printer_defaults.find(kPskTwoSided) !=
             std::string::npos);
 #else
   NOTIMPLEMENTED();
 #endif
 
     DictionaryValue settings_info;
     settings_info.SetBoolean(kDisableColorOption, !supports_color);
     if (!supports_color) {
       settings_info.SetBoolean(kSetColorAsDefault, false);
     } else {
        settings_info.SetBoolean(kSetColorAsDefault,
                                 PrintPreviewHandler::last_used_color_setting_);
     }
     settings_info.SetBoolean(kSetDuplexAsDefault, set_duplex_as_default);
+    settings_info.SetInteger(kPrinterColorSpace, printer_color_space);
     BrowserThread::PostTask(
         BrowserThread::UI, FROM_HERE,
         NewRunnableMethod(this,
                           &PrintSystemTaskProxy::SendPrinterCapabilities,
                           settings_info.DeepCopy()));
   }
 
   void SendPrinterCapabilities(DictionaryValue* settings_info) {
     if (handler_)
       handler_->SendPrinterCapabilities(*settings_info);
@@ skipping 211 matching lines @@
   if (initiator_tab) {
     RenderViewHost* rvh = initiator_tab->render_view_host();
     rvh->Send(new PrintMsg_ResetScriptedPrintCount(rvh->routing_id()));
   }
 
   scoped_ptr<DictionaryValue> settings(GetSettingsDictionary(args));
   if (!settings.get())
     return;
 
   // Storing last used color setting.
-  settings->GetBoolean("color", &last_used_color_setting_);
+  int color_mode;
+  if (!settings->GetInteger(printing::kSettingColor, &color_mode))
+    color_mode = printing::GRAY;
+  last_used_color_setting_ = (color_mode != printing::GRAY);
 
   bool print_to_pdf = false;
   settings->GetBoolean(printing::kSettingPrintToPDF, &print_to_pdf);
 
   settings->SetBoolean(printing::kSettingHeaderFooterEnabled, false);
 
   TabContentsWrapper* preview_tab_wrapper =
       TabContentsWrapper::GetCurrentWrapperForContents(preview_tab());
 
   bool print_to_cloud = settings->HasKey(printing::kSettingCloudPrintId);
@@ skipping 387 matching lines @@
     return;
 
   // We no longer require the initiator tab details. Remove those details
   // associated with the preview tab to allow the initiator tab to create
   // another preview tab.
   printing::PrintPreviewTabController* tab_controller =
      printing::PrintPreviewTabController::GetInstance();
   if (tab_controller)
     tab_controller->EraseInitiatorTabInfo(preview_tab_wrapper());
 }