Adding support to retrieve remaining and total space on disk/file shelf.

Adding support to retrieve remaining and total space on disk/file shelf.

BUG=chromium-os:19851
TEST=manual on Cr48.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102130

[zel, 2011-09-02 21:37:34]

http://codereview.chromium.org/7826037/diff/1/chrome/browser/chromeos/cros/mo...
File chrome/browser/chromeos/cros/mount_library.cc (right):

http://codereview.chromium.org/7826037/diff/1/chrome/browser/chromeos/cros/mo...
chrome/browser/chromeos/cros/mount_library.cc:228:
libcros_proxy_->CallGetSizeStats(mount_path, &GetSizeStatsCallback,
You might want to inline that routine here as well.
So, why is this in libcros? is there anything ChromeOS specific about this call?
can it simply run on any Linux distro?

http://codereview.chromium.org/7826037/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_file_browser_private_api.cc (right):

http://codereview.chromium.org/7826037/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_file_browser_private_api.cc:1312: if
(!args_->GetString(0, &mount_url)) {
nit: no {}

[tonibarzic, 2011-09-02 21:59:01]

http://codereview.chromium.org/7826037/diff/1/chrome/browser/chromeos/cros/mo...
File chrome/browser/chromeos/cros/mount_library.cc (right):

http://codereview.chromium.org/7826037/diff/1/chrome/browser/chromeos/cros/mo...
chrome/browser/chromeos/cros/mount_library.cc:228:
libcros_proxy_->CallGetSizeStats(mount_path, &GetSizeStatsCallback,
On 2011/09/02 21:37:34, zel wrote:
> You might want to inline that routine here as well.
> So, why is this in libcros? is there anything ChromeOS specific about this
call?
> can it simply run on any Linux distro?

It seemed like a good idea to keep system calls in chromeOS code base,
but yeah, it should work on any Linux distro..

http://codereview.chromium.org/7826037/diff/1/chrome/browser/extensions/exten...
File chrome/browser/extensions/extension_file_browser_private_api.cc (right):

http://codereview.chromium.org/7826037/diff/1/chrome/browser/extensions/exten...
chrome/browser/extensions/extension_file_browser_private_api.cc:1312: if
(!args_->GetString(0, &mount_url)) {
On 2011/09/02 21:37:34, zel wrote:
> nit: no {}

Done.

[zel, 2011-09-02 22:00:58]

http://codereview.chromium.org/7826037/diff/1/chrome/browser/chromeos/cros/mo...
File chrome/browser/chromeos/cros/mount_library.cc (right):

http://codereview.chromium.org/7826037/diff/1/chrome/browser/chromeos/cros/mo...
chrome/browser/chromeos/cros/mount_library.cc:228:
libcros_proxy_->CallGetSizeStats(mount_path, &GetSizeStatsCallback,
On 2011/09/02 21:59:01, tonibarzic wrote:
> On 2011/09/02 21:37:34, zel wrote:
> > You might want to inline that routine here as well.
> > So, why is this in libcros? is there anything ChromeOS specific about this
> call?
> > can it simply run on any Linux distro?
> 
> It seemed like a good idea to keep system calls in chromeOS code base,
> but yeah, it should work on any Linux distro..

We should move such functionality here into mount_library.cc instead. There is
no reason to bloat the surface of libcros.

[rginda, 2011-09-06 21:20:02]

http://codereview.chromium.org/7826037/diff/1012/chrome/common/extensions/api...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/7826037/diff/1012/chrome/common/extensions/api...
chrome/common/extensions/api/extension_api.json:6643: "type": "integer",
Can we get integer bytes instead of kilobytes?

[tbarzic, 2011-09-06 21:31:44]

http://codereview.chromium.org/7826037/diff/1012/chrome/common/extensions/api...
File chrome/common/extensions/api/extension_api.json (right):

http://codereview.chromium.org/7826037/diff/1012/chrome/common/extensions/api...
chrome/common/extensions/api/extension_api.json:6643: "type": "integer",
On 2011/09/06 21:20:02, rginda wrote:
> Can we get integer bytes instead of kilobytes?

I'm not sure... can we pass int64 here? (if we can it shouldn't be a problem)

[rginda, 2011-09-06 21:38:58]

http://codereview.chromium.org/7826037/diff/1012/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_file_browser_private_api.cc (right):

http://codereview.chromium.org/7826037/diff/1012/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_file_browser_private_api.cc:1295: #endif
Is this supposed to fall through to the PostTask, or should it return without
posting?

[tonibarzic, 2011-09-06 21:45:32]

http://codereview.chromium.org/7826037/diff/1012/chrome/browser/extensions/ex...
File chrome/browser/extensions/extension_file_browser_private_api.cc (right):

http://codereview.chromium.org/7826037/diff/1012/chrome/browser/extensions/ex...
chrome/browser/extensions/extension_file_browser_private_api.cc:1295: #endif
On 2011/09/06 21:38:58, rginda wrote:
> Is this supposed to fall through to the PostTask, or should it return without
> posting?

it's supposed to fall through..

[rginda, 2011-09-06 22:11:34]

On 2011/09/06 21:31:44, tbarzic wrote:
>
http://codereview.chromium.org/7826037/diff/1012/chrome/common/extensions/api...
> File chrome/common/extensions/api/extension_api.json (right):
> 
>
http://codereview.chromium.org/7826037/diff/1012/chrome/common/extensions/api...
> chrome/common/extensions/api/extension_api.json:6643: "type": "integer",
> On 2011/09/06 21:20:02, rginda wrote:
> > Can we get integer bytes instead of kilobytes?
> 
> I'm not sure... can we pass int64 here? (if we can it shouldn't be a problem)

I don't know if the extension api allows int64.  If not, I guess KB will have to
do.  FWIW, JavaScript will lose integer precision above 2^53, but that should be
enough for this purpose.

[zel, 2011-09-07 00:08:41]

there is no 64bit int support there, so go with KB for now

On Tue, Sep 6, 2011 at 3:11 PM, <rginda@chromium.org> wrote:

> On 2011/09/06 21:31:44, tbarzic wrote:
>
> http://codereview.chromium.**org/7826037/diff/1012/chrome/**
>
common/extensions/api/**extension_api.json<http://codereview.chromium.org/7826037/diff/1012/chrome/common/extensions/api/extension_api.json>
>
>> File chrome/common/extensions/api/**extension_api.json (right):
>>
>
>
> http://codereview.chromium.**org/7826037/diff/1012/chrome/**
>
common/extensions/api/**extension_api.json#newcode6643<http://codereview.chromium.org/7826037/diff/1012/chrome/common/extensions/api/extension_api.json#newcode6643>
>
>> chrome/common/extensions/api/**extension_api.json:6643: "type":
>> "integer",
>> On 2011/09/06 21:20:02, rginda wrote:
>> > Can we get integer bytes instead of kilobytes?
>>
>
>  I'm not sure... can we pass int64 here? (if we can it shouldn't be a
>> problem)
>>
>
> I don't know if the extension api allows int64.  If not, I guess KB will
> have to
> do.  FWIW, JavaScript will lose integer precision above 2^53, but that
> should be
> enough for this purpose.
>
>
>
>
>
http://codereview.chromium.**org/7826037/<http://codereview.chromium.org/7826...
>

[rginda, 2011-09-12 22:31:57]

LGTM

[zel, 2011-09-21 00:58:19]

LGTM

[commit-bot: I haz the power, 2011-09-21 05:16:15]

Presubmit check for 7826037-16001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/common/extensions/api/extension_api.json

Presubmit checks took 1.6s to calculate.