Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Unified Diff: chrome/browser/ssl/ssl_blocking_page.cc

Issue 7826036: Don't crash if DontProceed is chosen on the SSL interstitial page after Proceed is chosen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a browser test Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_blocking_page.cc
diff --git a/chrome/browser/ssl/ssl_blocking_page.cc b/chrome/browser/ssl/ssl_blocking_page.cc
index 2f65292db5364232a47ed1467cb90a933be9049b..79277029769918a9008074cf734b87732ee86294 100644
--- a/chrome/browser/ssl/ssl_blocking_page.cc
+++ b/chrome/browser/ssl/ssl_blocking_page.cc
@@ -146,7 +146,11 @@ void SSLBlockingPage::DontProceed() {
}
void SSLBlockingPage::NotifyDenyCertificate() {
- DCHECK(callback_);
+ // It's possible that callback_ may not exist if the user clicks "Proceed"
+ // followed by pressing the back button before the interstitial is hidden.
+ // In that case the certificate will still be treated as allowed.
+ if (!callback_)
+ return;
callback_->Run(handler_, false);
delete callback_;
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698