Don't crash if DontProceed is chosen on the SSL interstitial page after Proceed is chosen.

chrome/browser/ssl/ssl_browser_tests.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/time.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/tabs/tab_strip_model.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_navigator.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
+#include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "content/browser/renderer_host/render_view_host.h"
 #include "content/browser/tab_contents/interstitial_page.h"
 #include "content/browser/tab_contents/navigation_entry.h"
 #include "content/browser/tab_contents/tab_contents.h"
 #include "content/common/notification_service.h"
 #include "net/base/cert_status_flags.h"
 #include "net/test/test_server.h"
@@ skipping 446 matching lines @@
       browser()->AddSelectedTabWithURL(url, PageTransition::TYPED);
   ui_test_utils::WaitForLoadStop(tab2->tab_contents());
 
   // Verify our assumption that there was no prior navigation.
   EXPECT_FALSE(browser()->command_updater()->IsCommandEnabled(IDC_BACK));
 
   // We should have an interstitial page showing.
   ASSERT_TRUE(tab2->tab_contents()->interstitial_page());
 }
 
+IN_PROC_BROWSER_TEST_F(SSLUITest, TestBadHTTPSDownload) {
+  ASSERT_TRUE(test_server()->Start());
+  ASSERT_TRUE(https_server_expired_.Start());
+  GURL url_non_dangerous = test_server()->GetURL("");
+  GURL url_dangerous = https_server_expired_.GetURL(
+      "files/downloads/dangerous/dangerous.exe");
+
+  // Visit a non-dangerous page.
+  ui_test_utils::NavigateToURL(browser(), url_non_dangerous);
+
+  // Now, start a transition to dangerous download.
+  {
+    ui_test_utils::WindowedNotificationObserver observer(
+        content::NOTIFICATION_LOAD_STOP, NotificationService::AllSources());
+    browser::NavigateParams navigate_params(browser(), url_dangerous,
+                                            PageTransition::TYPED);
+    browser::Navigate(&navigate_params);
+    observer.Wait();
+  }
+
+  // Proceed through the SSL interstitial. This doesn't use
+  // |ProceedThroughInterstitial| since no page load will commit.
+  TabContents* tab = browser()->GetSelectedTabContents();
+  ASSERT_TRUE(tab != NULL);
+  ASSERT_TRUE(tab->interstitial_page() != NULL);
+  {
+    ui_test_utils::WindowedNotificationObserver observer(
+        chrome::NOTIFICATION_DOWNLOAD_INITIATED,
+        NotificationService::AllSources());
+    tab->interstitial_page()->Proceed();
+    observer.Wait();
+  }
+
+  // There should still be an interstitial at this point. Press the
+  // back button on the browser. Note that this doesn't wait for a
+  // NAV_ENTRY_COMMITTED notification because going back with an
+  // active interstitial simply hides the interstitial.
+  ASSERT_TRUE(tab->interstitial_page() != NULL);
+  EXPECT_TRUE(browser()->CanGoBack());
+  browser()->GoBack(CURRENT_TAB);
+}
+
 //
 // Insecure content
 //
 
 // Visits a page that displays insecure content.
 IN_PROC_BROWSER_TEST_F(SSLUITest, TestDisplaysInsecureContent) {
   ASSERT_TRUE(test_server()->Start());
   ASSERT_TRUE(https_server_.Start());
 
   std::string replacement_path;
@@ skipping 752 matching lines @@
 
 // Visit a page over https that contains a frame with a redirect.
 
 // XMLHttpRequest insecure content in synchronous mode.
 
 // XMLHttpRequest insecure content in asynchronous mode.
 
 // XMLHttpRequest over bad ssl in synchronous mode.
 
 // XMLHttpRequest over OK ssl in synchronous mode.