Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Unified Diff: ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons

Issue 7826017: Add PPB_Fullscreen;0.5. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/private/ppb_flash_fullscreen.h ('k') | ppapi/ppapi_tests.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons
===================================================================
--- ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons (revision 102885)
+++ ppapi/native_client/tests/ppapi_browser/ppb_fullscreen/nacl.scons (working copy)
@@ -39,8 +39,14 @@
# ERROR:render_widget_host_view_mac.mm(344)] Not implemented reached in virtual
# void RenderWidgetHost ViewMac::InitAsFullscreen(RenderWidgetHostView *)Full
# screen not implemented on Mac
-env.AddNodeToTestSuite(node,
- ['chrome_browser_tests'],
- 'run_ppapi_ppb_fullscreen_browser_test',
- is_broken=(env.PPAPIBrowserTesterIsBroken() or
- env.Bit('host_mac')))
+env.AddNodeToTestSuite(
+ node,
+ ['chrome_browser_tests'],
+ 'run_ppapi_ppb_fullscreen_browser_test',
+ # New PPB_Fullscreen_Dev implementation only allows transitions to
+ # fullscreen after a user gesture. Until PPB_Testing has the capabilities
+ # to trigger those, we cannot test this automatically.
+ # TODO(polina): update the test to work manually with the new
+ # implementation while we are sorting out the above issue.
+ #is_broken=(env.PPAPIBrowserTesterIsBroken() or env.Bit('host_mac')))
+ is_broken=True)
« no previous file with comments | « ppapi/c/private/ppb_flash_fullscreen.h ('k') | ppapi/ppapi_tests.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698