Add PPB_Fullscreen;0.5.

webkit/plugins/ppapi/ppapi_webplugin_impl.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppapi_webplugin_impl.h"
 
 #include <cmath>
 
 #include "base/message_loop.h"
 #include "googleurl/src/gurl.h"
@@ skipping 100 matching lines @@
   // The object is expected to be retained before it is returned.
   WebKit::WebBindings::retainObject(message_channel_np_object);
   return message_channel_np_object;
 }
 
 bool WebPluginImpl::getFormValue(WebString* value) {
   return false;
 }
 
 void WebPluginImpl::paint(WebCanvas* canvas, const WebRect& rect) {
-  if (!instance_->IsFullscreenOrPending())
+  if (!instance_->IsFullscreenOrPending() &&
+      !instance_->IsFullscreenOrPending_Dev())
     instance_->Paint(canvas, plugin_rect_, rect);

[piman, 2011/09/09 01:33:44]

Maybe I'm confused about the implementation, but shouldn't Paint be called here
if in the "new" fullscreen mode? If not, when/how does Paint get called? Same
with ViewChanged and HandleInputEvent below.

[jeremya, 2011/09/09 17:45:35]

I think you're right -- in the old fullscreen mode, the widget did its own
painting, event handling, etc.

[polina, 2011/09/26 21:57:00]

I did not have the full background on the differences between the old and the
new implementation. The code should make more sense now.

 }
 
 void WebPluginImpl::updateGeometry(
     const WebRect& window_rect,
     const WebRect& clip_rect,
     const WebVector<WebRect>& cut_outs_rects,
     bool is_visible) {
   plugin_rect_ = window_rect;
-  if (!instance_->IsFullscreenOrPending())
+  if (!instance_->IsFullscreenOrPending() &&
+      !instance_->IsFullscreenOrPending_Dev())
     instance_->ViewChanged(plugin_rect_, clip_rect);
 }
 
 void WebPluginImpl::updateFocus(bool focused) {
   instance_->SetWebKitFocus(focused);
 }
 
 void WebPluginImpl::updateVisibility(bool visible) {
 }
 
 bool WebPluginImpl::acceptsInputEvents() {
   return true;
 }
 
 bool WebPluginImpl::handleInputEvent(const WebKit::WebInputEvent& event,
                                      WebKit::WebCursorInfo& cursor_info) {
-  if (instance_->IsFullscreenOrPending())
+  if (instance_->IsFullscreenOrPending() ||
+      instance_->IsFullscreenOrPending_Dev())
     return false;
   return instance_->HandleInputEvent(event, &cursor_info);
 }
 
 void WebPluginImpl::didReceiveResponse(
     const WebKit::WebURLResponse& response) {
   DCHECK(!document_loader_);
 
   document_loader_ = new PPB_URLLoader_Impl(instance_->pp_instance(), true);
   document_loader_->didReceiveResponse(NULL, response);
@@ skipping 78 matching lines @@
                               WebKit::WebCanvas* canvas) {
   return instance_->PrintPage(page_number, canvas);
 }
 
 void WebPluginImpl::printEnd() {
   return instance_->PrintEnd();
 }
 
 }  // namespace ppapi
 }  // namespace webkit