Add PPB_Fullscreen;0.5.

ppapi/proxy/ppp_instance_proxy.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/proxy/ppp_instance_proxy.h"
 
 #include <algorithm>
 
 #include "ppapi/c/dev/ppb_fullscreen_dev.h"
 #include "ppapi/c/pp_var.h"
 #include "ppapi/c/ppb_core.h"
+#include "ppapi/c/ppb_fullscreen.h"
 #include "ppapi/c/ppp_instance.h"
 #include "ppapi/proxy/host_dispatcher.h"
 #include "ppapi/proxy/plugin_dispatcher.h"
 #include "ppapi/proxy/plugin_resource_tracker.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ppapi/proxy/ppb_url_loader_proxy.h"
 
 namespace ppapi {
 namespace proxy {
 
@@ skipping 19 matching lines @@
 
 void DidDestroy(PP_Instance instance) {
   HostDispatcher::GetForInstance(instance)->Send(
       new PpapiMsg_PPPInstance_DidDestroy(INTERFACE_ID_PPP_INSTANCE, instance));
 }
 
 void DidChangeView(PP_Instance instance,
                    const PP_Rect* position,
                    const PP_Rect* clip) {
   HostDispatcher* dispatcher = HostDispatcher::GetForInstance(instance);
-  const PPB_Fullscreen_Dev* fullscreen_interface =
+  const PPB_Fullscreen* fullscreen_interface =
+      static_cast<const PPB_Fullscreen*>(
+          dispatcher->GetLocalInterface(PPB_FULLSCREEN_INTERFACE));
+  DCHECK(fullscreen_interface);
+  const PPB_Fullscreen_Dev* fullscreen_dev_interface =
       static_cast<const PPB_Fullscreen_Dev*>(
           dispatcher->GetLocalInterface(PPB_FULLSCREEN_DEV_INTERFACE));
-  DCHECK(fullscreen_interface);
+  DCHECK(fullscreen_dev_interface);
   PP_Bool fullscreen = fullscreen_interface->IsFullscreen(instance);
+  PP_Bool fullscreen_dev  = fullscreen_dev_interface->IsFullscreen(instance);
+  PP_Bool fullscreen_either = ((fullscreen == PP_TRUE ||

[piman, 2011/09/09 01:33:44]

You need to send both flags separately if you want to implement IsFullscreen
consistently for in-process and out-of-process.
An alternative is to make IsFullscreen return true if we're in either mode, in
which case you would change the in-process implementation to report that, and
you could then remove IsFullscreen from the Dev interface because it's redundant
with the non-Dev.

[polina, 2011/09/26 21:57:00]

Done.

+                                fullscreen_dev == PP_TRUE) ?
+                               PP_TRUE : PP_FALSE);
   dispatcher->Send(
       new PpapiMsg_PPPInstance_DidChangeView(INTERFACE_ID_PPP_INSTANCE,
                                              instance, *position, *clip,
-                                             fullscreen));
+                                             fullscreen_either));
 }
 
 void DidChangeFocus(PP_Instance instance, PP_Bool has_focus) {
   HostDispatcher::GetForInstance(instance)->Send(
       new PpapiMsg_PPPInstance_DidChangeFocus(INTERFACE_ID_PPP_INSTANCE,
                                               instance, has_focus));
 }
 
 PP_Bool HandleDocumentLoad(PP_Instance instance,
                            PP_Resource url_loader) {
@@ skipping 149 matching lines @@
   // with. The plugin will normally take an additional reference which will keep
   // the resource alive in the plugin (and the one reference in the renderer
   // representing all plugin references).
   // Once all references at the plugin side are released, the renderer side will
   // be notified and release the reference added in HandleDocumentLoad() above.
   PluginResourceTracker::GetInstance()->ReleaseResource(plugin_loader);
 }
 
 }  // namespace proxy
 }  // namespace ppapi