[Mac] Enable CrZombie for all processes.

chrome/browser/chrome_browser_application_mac.mm

Index: chrome/browser/chrome_browser_application_mac.mm
diff --git a/chrome/browser/chrome_browser_application_mac.mm b/chrome/browser/chrome_browser_application_mac.mm
index 9394767788b26609101f9eb20d7a290e417f1d8b..e81ce1a3bb271a91495016fc9f2a9bd28b1e10f5 100644
--- a/chrome/browser/chrome_browser_application_mac.mm
+++ b/chrome/browser/chrome_browser_application_mac.mm
@@ -12,11 +12,11 @@
 #import "chrome/app/breakpad_mac.h"
 #import "chrome/browser/app_controller_mac.h"
 #include "chrome/browser/ui/browser_list.h"
-#import "chrome/browser/ui/cocoa/objc_method_swizzle.h"
-#import "chrome/browser/ui/cocoa/objc_zombie.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "content/browser/accessibility/browser_accessibility_state.h"
 #include "content/browser/renderer_host/render_view_host.h"
+#import "chrome/common/mac/objc_method_swizzle.h"

[Mark Mentovai, 2011/09/01 22:07:26]

Sort: chrome < content.

[Scott Hess - ex-Googler, 2011/09/01 23:31:57]

Done.  I looked right past that distinction.  Would be easier to notice if it
were goose/ versus content/.

[Mark Mentovai, 2011/09/01 23:55:23]

shess wrote:
Oh, how you goad me!

+#import "chrome/common/mac/objc_zombie.h"
 
 // The implementation of NSExceptions break various assumptions in the
 // Chrome code.  This category defines a replacement for
@@ -210,7 +210,7 @@ void SwizzleInit() {
 + (void)initialize {
   // Turn all deallocated Objective-C objects into zombies, keeping
   // the most recent 10,000 of them on the treadmill.
-  ObjcEvilDoers::ZombieEnable(YES, 10000);
+  ObjcEvilDoers::ZombieEnable(true, 10000);

[Mark Mentovai, 2011/09/01 22:07:26]

This uses that swap loop, right? Over all of the original 1000 objects (even if
the list is mostly sparse?) That will hopefully not suck.

I wouldn’t be opposed to putting a process-type check into ChromeMain to use
10000 for the browser process, and adding an explicit ZombieEnable call to the
one other file (shared by those tests).

[Scott Hess - ex-Googler, 2011/09/01 23:31:57]

I think I had originally coded up an alternative which did a smart memcpy(), but
decided that handling the case where the overlap was end+beg was maybe a little
aggressive.  Certainly doable, and for something called millions of times per
launch I'd be all for it.

I just instrumented a build with TimeTicks, and for the entire block under the
lock:
  Convert old count 1000 to new count 10000 took 0 ms
I was inclined to just leave it there, but it's easy to go deeper:
  Convert old count 1000 to new count 10000 took 207 us
  Convert old count 1000 to new count 10000 took 200 us
  Convert old count 1000 to new count 10000 took 208 us
For reference, the longest base case is:
  Convert old count 0 to new count 1000 took 133 us
though most of them were between 90 and 100 us.
Hmm.  Would it make sense (or anti-sense) to shift this #if OS_MACOSX block down
to the #if OS_POSIX section?  Then it would have process_type right there.  It
would also be reasonable to push the zombie-enable after the --version check.

[Mark Mentovai, 2011/09/01 23:55:23]

shess wrote:
I guess that sounds about right.
In this tiny POSIX-specific block of main, I don’t think the ordering of most
steps matters that much.

(Except that there are probably some small subtle relative-ordering things. I
put EnableCFBundleBlocker after SetUpBundleOverrides intentionally: while
EnableCFBundleBlocker itself doesn’t depend on bundle overrides, I wasn’t
positive that everything called by our blocker override function was free of
uses of the bundle override stuff. If I inverted the order of the two calls, I
was afraid someone would try to insert something in the middle that might try to
load a bundle.)

That said, it seems like the change you’re looking to make wouldn’t have any
ordering concerns of this sort, so pick something that sounds good and let’s
roll with it. Practically, I think of everything in that BasicStartupComplete
function running at pretty much the same time in the context of the greater
ChromeMain scheme.

 }
 
 - (id)init {