[Mac] Enable CrZombie for all processes.

chrome/app/chrome_main.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/app/chrome_main.h"
 
 #include "base/command_line.h"
 #include "base/debug/debugger.h"
 #include "base/i18n/icu_util.h"
 #include "base/lazy_instance.h"
@@ skipping 48 matching lines @@
 
 #if defined(OS_MACOSX)
 #include "base/mac/mac_util.h"
 #include "base/mac/os_crash_dumps.h"
 #include "base/mach_ipc_mac.h"
 #include "base/system_monitor/system_monitor.h"
 #include "chrome/app/breakpad_mac.h"
 #include "chrome/browser/mac/relauncher.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/mac/cfbundle_blocker.h"
+#include "chrome/common/mac/objc_zombie.h"
 #include "content/browser/mach_broker_mac.h"
 #include "grit/chromium_strings.h"
 #include "third_party/WebKit/Source/WebKit/mac/WebCoreSupport/WebSystemInterface.h"
 #include "ui/base/l10n/l10n_util_mac.h"
 #endif
 
 #if defined(OS_POSIX)
 #include <locale.h>
 #include <signal.h>
 #endif
@@ skipping 498 matching lines @@
  public:
   virtual bool BasicStartupComplete(
       int* exit_code,
       base::mac::ScopedNSAutoreleasePool* autorelease_pool) OVERRIDE {
     autorelease_pool_ = autorelease_pool;
 #if defined(OS_CHROMEOS)
     chromeos::BootTimesLoader::Get()->SaveChromeMainStats();
 #endif
 
 #if defined(OS_MACOSX)
+    // TODO(shess): Enable zombies for everyone.  http://crbug.com/94551
+    DCHECK(ObjcEvilDoers::ZombieEnable(true, 1000));

[Scott Hess - ex-Googler, 2011/09/01 21:58:22]

This means that only debug builds will do this.  I am not averse to shipping it
to the world, but only in canary form, and I wouldn't mind having a trivial
'drover ...' command-line to accomplish it, if the first canary blows.

[Mark Mentovai, 2011/09/01 22:00:13]

shess wrote:
I’m curious about what you’re afraid of. The real benefit to the Objective-C
zombies in the browser has been that they’ve been running on user machines
catching things we never would have caught if we had been left to our own meager
resources.

[Mark Mentovai, 2011/09/01 22:07:26]

OK, sounds reasonable for this to be debug-only for a week or two.

[Scott Hess - ex-Googler, 2011/09/01 23:31:57]

Man, you're too easy :-).  That said, I'm certainly willing to wait until after
the long weekend.

[Mark Mentovai, 2011/09/01 23:55:23]

shess wrote:
Easy? I thought that the question tended more toward the iron-fist end of the
spectrum. I saw you had a TODO here to turn it on, but I pressed you on the
matter anyway. :)

     chrome_main::SetUpBundleOverrides();
     chrome::common::mac::EnableCFBundleBlocker();
 #endif
 
     Profiling::ProcessStarted();
 
     const CommandLine& command_line = *CommandLine::ForCurrentProcess();
     std::string process_type =
         command_line.GetSwitchValueASCII(switches::kProcessType);
 
@@ skipping 356 matching lines @@
 
 #if defined(OS_MACOSX) && defined(GOOGLE_CHROME_BUILD)
   // TODO(mark): See the TODO(mark) at InitCrashReporter.
   DestructCrashReporter();
 #endif  // OS_MACOSX && GOOGLE_CHROME_BUILD
 
   content::ContentMainEnd();
 
   return exit_code;
 }