Implement chrome.experimental.downloads.search()

chrome/browser/extensions/extension_downloads_api.h

Index: chrome/browser/extensions/extension_downloads_api.h
diff --git a/chrome/browser/extensions/extension_downloads_api.h b/chrome/browser/extensions/extension_downloads_api.h
index b0cf0e90cc3db310d6ae215aa9250fcfbb2156c4..f63f9bc79eaf3645f91e88826cb89335cf89f18e 100644
--- a/chrome/browser/extensions/extension_downloads_api.h
+++ b/chrome/browser/extensions/extension_downloads_api.h
@@ -15,6 +15,7 @@
 #include "base/string16.h"
 #include "chrome/browser/extensions/extension_function.h"
 #include "content/browser/download/download_item.h"
+#include "content/browser/download/download_query.h"

[asanka, 2011/10/20 19:29:16]

Nit: ordering.

 #include "content/browser/download/download_manager.h"
 
 namespace base {
@@ -140,6 +141,14 @@ class DownloadsSearchFunction : public SyncDownloadsFunction {
   virtual void RunInternal() OVERRIDE;
 
  private:
+  template <typename ValueType>
+  bool Parse(base::DictionaryValue* json, const char* json_name,
+             download_util::DownloadQuery::FilterFieldName filter_name);
+
+  download_util::DownloadQuery query_;

[cbentzel, 2011/10/20 18:18:53]

Could you make this a scoped_ptr so you can just forward declare DownloadQuery?
It does mean that FilterFieldName would need to move out into a separate
header/class, although I think that Parse could be done separately.

+  int get_id_;
+  bool has_get_id_;
+
   DISALLOW_COPY_AND_ASSIGN(DownloadsSearchFunction);
 };