Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 7825024: For Touch: remove some menu items for experimentation, adjust sizes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: copyright Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/wrench_menu_model_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/toolbar/wrench_menu_model.cc
diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.cc b/chrome/browser/ui/toolbar/wrench_menu_model.cc
index 39d570cf3ea7370fea725e9c7d864a6f6cb3345f..7b26e51f45efe21aada9c7fc4bac26e458e26cbe 100644
--- a/chrome/browser/ui/toolbar/wrench_menu_model.cc
+++ b/chrome/browser/ui/toolbar/wrench_menu_model.cc
@@ -406,15 +406,11 @@ WrenchMenuModel::WrenchMenuModel()
tabstrip_model_(NULL) {
}
+#if !defined(OS_CHROMEOS)
void WrenchMenuModel::Build() {
AddItemWithStringId(IDC_NEW_TAB, IDS_NEW_TAB);
AddItemWithStringId(IDC_NEW_WINDOW, IDS_NEW_WINDOW);
-#if defined(OS_CHROMEOS)
- if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kGuestSession))
- AddItemWithStringId(IDC_NEW_INCOGNITO_WINDOW, IDS_NEW_INCOGNITO_WINDOW);
-#else
AddItemWithStringId(IDC_NEW_INCOGNITO_WINDOW, IDS_NEW_INCOGNITO_WINDOW);
-#endif
bookmark_sub_menu_model_.reset(new BookmarkSubMenuModel(this, browser_));
AddSubMenuWithStringId(IDC_BOOKMARKS_MENU, IDS_BOOKMARKS_MENU,
@@ -470,7 +466,6 @@ void WrenchMenuModel::Build() {
AddItemWithStringId(IDC_SHOW_DOWNLOADS, IDS_SHOW_DOWNLOADS);
AddSeparator();
-#if !defined(OS_CHROMEOS)
if (browser_->profile()->GetOriginalProfile()->IsSyncAccessible()) {
const string16 short_product_name =
l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME);
@@ -478,11 +473,8 @@ void WrenchMenuModel::Build() {
IDS_SHOW_SYNC_SETUP, short_product_name));
AddSeparator();
}
-#endif
-#if defined(OS_CHROMEOS)
- AddItemWithStringId(IDC_OPTIONS, IDS_SETTINGS);
-#elif defined(OS_MACOSX)
+#if defined(OS_MACOSX)
AddItemWithStringId(IDC_OPTIONS, IDS_PREFERENCES);
#elif defined(TOOLKIT_USES_GTK)
string16 preferences = gtk_util::GetStockPreferencesMenuLabel();
@@ -494,11 +486,7 @@ void WrenchMenuModel::Build() {
AddItemWithStringId(IDC_OPTIONS, IDS_OPTIONS);
#endif
-#if defined(OS_CHROMEOS)
- const string16 product_name = l10n_util::GetStringUTF16(IDS_PRODUCT_OS_NAME);
-#else
const string16 product_name = l10n_util::GetStringUTF16(IDS_PRODUCT_NAME);
-#endif
AddItem(IDC_ABOUT, l10n_util::GetStringFUTF16(IDS_ABOUT, product_name));
string16 num_background_pages = base::FormatNumber(
TaskManager::GetBackgroundPageCount());
@@ -516,29 +504,13 @@ void WrenchMenuModel::Build() {
#endif
AddItemWithStringId(IDC_HELP_PAGE, IDS_HELP_PAGE);
-#if defined(OS_CHROMEOS)
- ResourceBundle& rb = ResourceBundle::GetSharedInstance();
- // Use an icon for IDC_HELP_PAGE menu item.
- SetIcon(GetIndexOfCommandId(IDC_HELP_PAGE),
- *rb.GetBitmapNamed(IDR_HELP_MENU));
-
- // Show IDC_FEEDBACK in top-tier wrench menu for ChromeOS.
- AddItemWithStringId(IDC_FEEDBACK, IDS_FEEDBACK);
-#endif
if (browser_defaults::kShowExitMenuItem) {
AddSeparator();
-#if defined(OS_CHROMEOS)
- if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kGuestSession)) {
- AddItemWithStringId(IDC_EXIT, IDS_EXIT_GUEST_MODE);
- } else {
- AddItemWithStringId(IDC_EXIT, IDS_SIGN_OUT);
- }
-#else
AddItemWithStringId(IDC_EXIT, IDS_EXIT);
-#endif
}
}
+#endif // !OS_CHROMEOS
void WrenchMenuModel::CreateCutCopyPaste() {
// WARNING: views/wrench_menu assumes these items are added in this order. If
« no previous file with comments | « no previous file | chrome/browser/ui/toolbar/wrench_menu_model_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698