Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 7825024: For Touch: remove some menu items for experimentation, adjust sizes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/wrench_menu_model.h" 5 #include "chrome/browser/ui/toolbar/wrench_menu_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 388 matching lines...) Expand 10 before | Expand all | Expand 10 after
399 399
400 // For testing. 400 // For testing.
401 WrenchMenuModel::WrenchMenuModel() 401 WrenchMenuModel::WrenchMenuModel()
402 : ALLOW_THIS_IN_INITIALIZER_LIST(ui::SimpleMenuModel(this)), 402 : ALLOW_THIS_IN_INITIALIZER_LIST(ui::SimpleMenuModel(this)),
403 provider_(NULL), 403 provider_(NULL),
404 browser_(NULL), 404 browser_(NULL),
405 tabstrip_model_(NULL) { 405 tabstrip_model_(NULL) {
406 } 406 }
407 407
408 void WrenchMenuModel::Build() { 408 void WrenchMenuModel::Build() {
409 #if !defined(TOUCH_UI)
sky 2011/09/02 00:43:04 This code is such a mess of ifdefs that it's proba
409 AddItemWithStringId(IDC_NEW_TAB, IDS_NEW_TAB); 410 AddItemWithStringId(IDC_NEW_TAB, IDS_NEW_TAB);
410 AddItemWithStringId(IDC_NEW_WINDOW, IDS_NEW_WINDOW); 411 AddItemWithStringId(IDC_NEW_WINDOW, IDS_NEW_WINDOW);
411 #if defined(OS_CHROMEOS) 412 #if defined(OS_CHROMEOS)
412 if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kGuestSession)) 413 if (!CommandLine::ForCurrentProcess()->HasSwitch(switches::kGuestSession))
413 AddItemWithStringId(IDC_NEW_INCOGNITO_WINDOW, IDS_NEW_INCOGNITO_WINDOW); 414 AddItemWithStringId(IDC_NEW_INCOGNITO_WINDOW, IDS_NEW_INCOGNITO_WINDOW);
414 #else 415 #else
415 AddItemWithStringId(IDC_NEW_INCOGNITO_WINDOW, IDS_NEW_INCOGNITO_WINDOW); 416 AddItemWithStringId(IDC_NEW_INCOGNITO_WINDOW, IDS_NEW_INCOGNITO_WINDOW);
416 #endif 417 #endif
417 418
418 AddSeparator(); 419 AddSeparator();
(...skipping 26 matching lines...) Expand all
445 zoom_menu_item_model_->AddItemWithImage( 446 zoom_menu_item_model_->AddItemWithImage(
446 IDC_FULLSCREEN, IDR_FULLSCREEN_MENU_BUTTON); 447 IDC_FULLSCREEN, IDR_FULLSCREEN_MENU_BUTTON);
447 AddButtonItem(IDC_ZOOM_MENU, zoom_menu_item_model_.get()); 448 AddButtonItem(IDC_ZOOM_MENU, zoom_menu_item_model_.get());
448 #else 449 #else
449 // TODO(port): Move to the above. 450 // TODO(port): Move to the above.
450 CreateZoomFullscreen(); 451 CreateZoomFullscreen();
451 #endif 452 #endif
452 453
453 AddSeparator(); 454 AddSeparator();
454 AddItemWithStringId(IDC_SAVE_PAGE, IDS_SAVE_PAGE); 455 AddItemWithStringId(IDC_SAVE_PAGE, IDS_SAVE_PAGE);
456 #endif // !TOUCH_UI
455 AddItemWithStringId(IDC_FIND, IDS_FIND); 457 AddItemWithStringId(IDC_FIND, IDS_FIND);
456 AddItemWithStringId(IDC_PRINT, IDS_PRINT); 458 AddItemWithStringId(IDC_PRINT, IDS_PRINT);
457 459
458 tools_menu_model_.reset(new ToolsMenuModel(this, browser_)); 460 tools_menu_model_.reset(new ToolsMenuModel(this, browser_));
459 AddSubMenuWithStringId(IDC_ZOOM_MENU, IDS_TOOLS_MENU, 461 AddSubMenuWithStringId(IDC_ZOOM_MENU, IDS_TOOLS_MENU,
460 tools_menu_model_.get()); 462 tools_menu_model_.get());
461 463
462 AddSeparator(); 464 AddSeparator();
463 465
464 bookmark_sub_menu_model_.reset(new BookmarkSubMenuModel(this, browser_)); 466 bookmark_sub_menu_model_.reset(new BookmarkSubMenuModel(this, browser_));
465 AddSubMenuWithStringId(IDC_BOOKMARKS_MENU, IDS_BOOKMARKS_MENU, 467 AddSubMenuWithStringId(IDC_BOOKMARKS_MENU, IDS_BOOKMARKS_MENU,
466 bookmark_sub_menu_model_.get()); 468 bookmark_sub_menu_model_.get());
467 AddItemWithStringId(IDC_SHOW_HISTORY, IDS_SHOW_HISTORY); 469 AddItemWithStringId(IDC_SHOW_HISTORY, IDS_SHOW_HISTORY);
470 #if !defined(TOUCH_UI)
468 AddItemWithStringId(IDC_SHOW_DOWNLOADS, IDS_SHOW_DOWNLOADS); 471 AddItemWithStringId(IDC_SHOW_DOWNLOADS, IDS_SHOW_DOWNLOADS);
472 #endif // !TOUCH_UI
469 AddSeparator(); 473 AddSeparator();
470 474
471 #if !defined(OS_CHROMEOS) 475 #if !defined(OS_CHROMEOS)
472 if (browser_->profile()->GetOriginalProfile()->IsSyncAccessible()) { 476 if (browser_->profile()->GetOriginalProfile()->IsSyncAccessible()) {
473 const string16 short_product_name = 477 const string16 short_product_name =
474 l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME); 478 l10n_util::GetStringUTF16(IDS_SHORT_PRODUCT_NAME);
475 AddItem(IDC_SHOW_SYNC_SETUP, l10n_util::GetStringFUTF16( 479 AddItem(IDC_SHOW_SYNC_SETUP, l10n_util::GetStringFUTF16(
476 IDS_SHOW_SYNC_SETUP, short_product_name)); 480 IDS_SHOW_SYNC_SETUP, short_product_name));
477 AddSeparator(); 481 AddSeparator();
478 } 482 }
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
563 &enable_increment, &enable_decrement); 567 &enable_increment, &enable_decrement);
564 } 568 }
565 zoom_label_ = l10n_util::GetStringFUTF16( 569 zoom_label_ = l10n_util::GetStringFUTF16(
566 IDS_ZOOM_PERCENT, base::IntToString16(zoom_percent)); 570 IDS_ZOOM_PERCENT, base::IntToString16(zoom_percent));
567 } 571 }
568 572
569 string16 WrenchMenuModel::GetSyncMenuLabel() const { 573 string16 WrenchMenuModel::GetSyncMenuLabel() const {
570 return sync_ui_util::GetSyncMenuLabel( 574 return sync_ui_util::GetSyncMenuLabel(
571 browser_->profile()->GetOriginalProfile()->GetProfileSyncService()); 575 browser_->profile()->GetOriginalProfile()->GetProfileSyncService());
572 } 576 }
OLDNEW
« no previous file with comments | « no previous file | views/controls/menu/menu_item_view.cc » ('j') | views/controls/menu/menu_item_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698