Issue 7825006: Prune empty block scopes from scope tree

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7825006: Prune empty block scopes from scope tree (Closed)

Created:
9 years, 3 months ago by Steven

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Prune empty block scopes from scope tree BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9117

Patch Set 1 #

Total comments: 2

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+132 lines, -39 lines)			Patch
M	src/heap.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/parser.cc	View	2 chunks	+19 lines, -15 lines	0 comments	Download
M	src/scopes.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/scopes.cc	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	test/mjsunit/harmony/debug-blockscopes.js	View	7 chunks	+77 lines, -22 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM. http://codereview.chromium.org/7825006/diff/1/test/mjsunit/harmony/debug-blockscopes.js File test/mjsunit/harmony/debug-blockscopes.js (right): http://codereview.chromium.org/7825006/diff/1/test/mjsunit/harmony/debug-blockscopes.js#newcode309 test/mjsunit/harmony/debug-blockscopes.js:309: // Two variables in a block scope. Forgot ...

9 years, 3 months ago (2011-09-01 15:40:10 UTC) #2

Steven

9 years, 3 months ago (2011-09-02 12:43:43 UTC) #3

http://codereview.chromium.org/7825006/diff/1/test/mjsunit/harmony/debug-bloc...
File test/mjsunit/harmony/debug-blockscopes.js (right):

http://codereview.chromium.org/7825006/diff/1/test/mjsunit/harmony/debug-bloc...
test/mjsunit/harmony/debug-blockscopes.js:309: // Two variables in a block
scope.
Indeed.
On 2011/09/01 15:40:10, Jakob wrote:
> Forgot to edit the comment?

Expand Messages | Collapse Messages