Issue 7824038: Remove variable rewrites and the unneccesary Slot class.

Issue 7824038: Remove variable rewrites and the unneccesary Slot class. (Closed)

Created:
9 years, 3 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 3 months ago

Reviewers:
fschneider

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Remove variable rewrites and the unneccesary Slot class. R=fschneider@chromium.org BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9162

Patch Set 1 #

Total comments: 7

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1293 lines, -1627 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	25 chunks	+253 lines, -337 lines	2 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/ast.h	View	5 chunks	+1 line, -60 lines	0 comments	Download
M	src/ast.cc	View	3 chunks	+1 line, -9 lines	0 comments	Download
M	src/full-codegen.h	View	9 chunks	+41 lines, -28 lines	0 comments	Download
M	src/full-codegen.cc	View	4 chunks	+9 lines, -42 lines	0 comments	Download
M	src/hydrogen.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/hydrogen.cc	View	12 chunks	+228 lines, -206 lines	4 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	24 chunks	+279 lines, -365 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/liveedit.cc	View	3 chunks	+3 lines, -4 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	17 chunks	+28 lines, -19 lines	0 comments	Download
M	src/prettyprinter.h	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/prettyprinter.cc	View	4 chunks	+38 lines, -60 lines	0 comments	Download
M	src/scopeinfo.cc	View	4 chunks	+24 lines, -31 lines	0 comments	Download
M	src/scopes.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	src/scopes.cc	View	13 chunks	+53 lines, -35 lines	0 comments	Download
M	src/variables.h	View	4 chunks	+42 lines, -13 lines	1 comment	Download
M	src/variables.cc	View	2 chunks	+2 lines, -29 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	24 chunks	+275 lines, -366 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	test/mjsunit/compiler/delete.js	View	2 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM. http://codereview.chromium.org/7824038/diff/1/src/arm/full-codegen-arm.cc File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/7824038/diff/1/src/arm/full-codegen-arm.cc#newcode1816 src/arm/full-codegen-arm.cc:1816: // Global var, const, or let. Comment should ...

9 years, 3 months ago (2011-09-06 09:34:22 UTC) #2

Kevin Millikin (Chromium)

9 years, 3 months ago (2011-09-06 10:44:06 UTC) #3

http://codereview.chromium.org/7824038/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/7824038/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:1816: // Global var, const, or let.
On 2011/09/06 09:34:22, fschneider wrote:
> Comment should be a sentence and outside the if-statement.

I thought it was pretty clear that there was an implied subject.  I'll make it
wordier.

It definitely shouldn't be outside the if.

http://codereview.chromium.org/7824038/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

http://codereview.chromium.org/7824038/diff/1/src/hydrogen.cc#newcode4929
src/hydrogen.cc:4929: // FIXME.
On 2011/09/06 09:34:22, fschneider wrote:
> Is this a TODO?

Oops.  It was a TODO, but it's been fixed and I didn't delete the comment.

Expand Messages | Collapse Messages