Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 7823005: Adding ogv test file for media unit tests (Closed)

Created:
9 years, 3 months ago by vrk (LEFT CHROMIUM)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, acolwell+watch_chromium.org, annacc+watch_chromium.org, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing)
Visibility:
Public.

Description

Adding ogv test file for media unit tests. BUG=60215 TEST=test_shell_tests,media_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99838

Patch Set 1 #

Patch Set 2 : Undoing file rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A media/test/data/bear.ogv View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vrk (LEFT CHROMIUM)
When I submitted issue 7718017 to try bots, I got complaints regarding 2 of the ...
9 years, 3 months ago (2011-08-31 21:43:49 UTC) #1
vrk (LEFT CHROMIUM)
NVM on file renaming! The proprietary-ness of the MP4 file was the problem: I rebuilt ...
9 years, 3 months ago (2011-09-06 20:43:48 UTC) #2
acolwell GONE FROM CHROMIUM
9 years, 3 months ago (2011-09-06 22:09:51 UTC) #3
LGTM
On 2011/09/06 20:43:48, Victoria Kirst wrote:
> NVM on file renaming! 
> 
> The proprietary-ness of the MP4 file was the problem: I rebuilt without the
> proprietary branding and repro'd the "unknown file: Failure" message. This
means
> I can't use an mp4 in issue 7718017, and instead I'll use ogv.
> 
> So in this CL I got rid of the file renaming, now just adding an ogv!

Powered by Google App Engine
This is Rietveld 408576698