Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: chrome/browser/resources/print_preview/print_preview.js

Issue 7822014: Fix the print preview regression bug caused by r98926. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed a typo Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/renderer/print_web_view_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/print_preview/print_preview.js
diff --git a/chrome/browser/resources/print_preview/print_preview.js b/chrome/browser/resources/print_preview/print_preview.js
index c8fdcd657c0f8ca5e241ada807f9175c819cc328..80ef29c68585365b84afbae3274c52833ea86a0a 100644
--- a/chrome/browser/resources/print_preview/print_preview.js
+++ b/chrome/browser/resources/print_preview/print_preview.js
@@ -920,6 +920,9 @@ function onDidGetDefaultPageLayout(pageLayout) {
function reloadPreviewPages(previewUid, previewResponseId) {
if (!isExpectedPreviewResponse(previewResponseId))
return;
+
+ if (pageSettings.requestPrintPreviewIfNeeded())
dpapad 2011/09/01 21:20:53 Repeating our in person discussion, it seems bette
kmadhusu 2011/09/01 21:38:34 Done.
+ return;
hasPendingPreviewRequest = false;
cr.dispatchSimpleEvent(document, 'updatePrintButton');
@@ -976,6 +979,10 @@ function onDidPreviewPage(pageNumber, previewUid, previewResponseId) {
function updatePrintPreview(previewUid, previewResponseId) {
if (!isExpectedPreviewResponse(previewResponseId))
return;
+
+ if (pageSettings.requestPrintPreviewIfNeeded())
+ return;
+
hasPendingPreviewRequest = false;
hasPendingPrintReadyDocumentRequest = false;
« no previous file with comments | « no previous file | chrome/renderer/print_web_view_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698