Issue 7822009: Fix crash in CanFindIntranetURL() due to FixupUserInput() changing the AutocompleteInput's text_ ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7822009: Fix crash in CanFindIntranetURL() due to FixupUserInput() changing the AutocompleteInput's text_ ... (Closed)

Created:
9 years, 3 months ago by Peter Kasting

Modified:
9 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix crash in CanFindIntranetURL() due to FixupUserInput() changing the AutocompleteInput's text_ but not its parts_, and us newly trying to use those parts_ later. BUG=94158 TEST=Covered by unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99233

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -33 lines)			Patch
M	chrome/browser/autocomplete/autocomplete.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/autocomplete/autocomplete.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/autocomplete/history_provider.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/autocomplete/history_provider.cc	View		3 chunks	+13 lines, -7 lines	0 comments	Download
M	chrome/browser/autocomplete/history_quick_provider.cc	View		1 chunk	+1 line, -10 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider.cc	View		2 chunks	+7 lines, -12 lines	0 comments	Download
M	chrome/browser/autocomplete/history_url_provider_unittest.cc	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages