Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: Source/WebCore/webaudio/AudioNode.cpp

Issue 7821023: Merge 94262 - Add defensive bounds checking for AudioNode methods (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/835/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/webaudio/AudioNode.cpp
===================================================================
--- Source/WebCore/webaudio/AudioNode.cpp (revision 94266)
+++ Source/WebCore/webaudio/AudioNode.cpp (working copy)
@@ -100,12 +100,16 @@
AudioNodeInput* AudioNode::input(unsigned i)
{
- return m_inputs[i].get();
+ if (i < m_inputs.size())
+ return m_inputs[i].get();
+ return 0;
}
AudioNodeOutput* AudioNode::output(unsigned i)
{
- return m_outputs[i].get();
+ if (i < m_outputs.size())
+ return m_outputs[i].get();
+ return 0;
}
bool AudioNode::connect(AudioNode* destination, unsigned outputIndex, unsigned inputIndex)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698