Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 7821021: Enable nacl_helper by default. (Closed)

Created:
9 years, 3 months ago by Brad Chen
Modified:
9 years, 3 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Enable nacl_helper by default. BUG=92964, nativeclient:480 TEST=nacl_integration in chromium bots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99319

Patch Set 1 #

Patch Set 2 : Also re-enable NaCl for 32-bit Linux #

Total comments: 1

Patch Set 3 : Re-enable nacl tests on 32-bit linux, remove obsolete comment #

Patch Set 4 : Clean-up another comment #

Patch Set 5 : Eliminate --nacl-linux-helper flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -34 lines) Patch
M chrome/browser/extensions/extension_nacl_browsertest.cc View 1 2 4 chunks +0 lines, -16 lines 0 comments Download
M chrome/nacl/nacl_fork_delegate_linux.cc View 1 2 3 4 1 chunk +1 line, -6 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/zygote_host_linux.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M content/common/content_switches.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M content/common/content_switches.cc View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Brad Chen
Unless I see major problems I'd like to flip the switch later this afternoon.
9 years, 3 months ago (2011-09-01 19:47:28 UTC) #1
elijahtaylor (use chromium)
drive-by: there were tests I disabled for linux 32-bit in my CL as well, please ...
9 years, 3 months ago (2011-09-01 19:49:53 UTC) #2
Brad Chen
Done and done; Thanks! On 2011/09/01 19:49:53, elijahtaylor wrote: > drive-by: there were tests I ...
9 years, 3 months ago (2011-09-01 20:02:44 UTC) #3
elijahtaylor (use chromium)
LGTM (though I admit cluelessness on nacl-helper) On 2011/09/01 20:02:44, Brad Chen wrote: > Done ...
9 years, 3 months ago (2011-09-01 20:07:37 UTC) #4
Roland McGrath
It seems ill-advised to leave the same switch name --nacl-linux-helper and reverse its sense. Then ...
9 years, 3 months ago (2011-09-01 20:23:01 UTC) #5
Brad Chen
On Thu, Sep 1, 2011 at 1:23 PM, <mcgrathr@chromium.org> wrote: > It seems ill-advised to ...
9 years, 3 months ago (2011-09-01 20:28:59 UTC) #6
Brad Chen
On Thu, Sep 1, 2011 at 1:23 PM, <mcgrathr@chromium.org> wrote: > It seems ill-advised to ...
9 years, 3 months ago (2011-09-01 20:29:01 UTC) #7
Brad Chen
Adding John for content/ reviews.
9 years, 3 months ago (2011-09-01 20:42:27 UTC) #8
jam
content lgtm
9 years, 3 months ago (2011-09-01 21:44:06 UTC) #9
commit-bot: I haz the power
9 years, 3 months ago (2011-09-02 04:24:42 UTC) #10
Change committed as 99319

Powered by Google App Engine
This is Rietveld 408576698