Center the desktop if it's smaller than the frame.

Center the desktop if it's smaller than the frame.
Apply a drop-shadow to make it clear where the desktop edge is.
Fix desktop resize handling to cope respect the scaling setting.

BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99893

[Wez, 2011-09-01 00:23:21]

FYI

[Jamie, 2011-09-06 17:19:24]

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/choice.css
File remoting/webapp/me2mom/choice.css (right):

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/choice.c...
remoting/webapp/me2mom/choice.css:233: -webkit-box-shadow: 0 0 20px 0 black;
After consultation with Ken, I think we agreed to make this shadow smaller.

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_session.js (left):

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_session.js:359: this.plugin.height = height;
Don't you still need these last two lines in the case where you're not scaling?

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_session.js (right):

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_session.js:403: parentNode.style["margin-left"] =
-(this.plugin.width/2) + "px";
Please add a comment above the margin setters to explain that this is to keep
the plugin centred wrt its center point rather than its top-left.

[Wez, 2011-09-07 00:28:43]

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/choice.css
File remoting/webapp/me2mom/choice.css (right):

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/choice.c...
remoting/webapp/me2mom/choice.css:233: -webkit-box-shadow: 0 0 20px 0 black;
On 2011/09/06 17:19:25, Jamie wrote:
> After consultation with Ken, I think we agreed to make this shadow smaller.

Done.

I'll let Ken know we've done this, so he can take it for a spin and decide
whether we need something better.

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_session.js (left):

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_session.js:359: this.plugin.height = height;
On 2011/09/06 17:19:25, Jamie wrote:
> Don't you still need these last two lines in the case where you're not
scaling?

setScaleToFit() already has those lines in the not-scaling case.

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/client_s...
File remoting/webapp/me2mom/client_session.js (right):

http://codereview.chromium.org/7821017/diff/1/remoting/webapp/me2mom/client_s...
remoting/webapp/me2mom/client_session.js:403: parentNode.style["margin-left"] =
-(this.plugin.width/2) + "px";
On 2011/09/06 17:19:25, Jamie wrote:
> Please add a comment above the margin setters to explain that this is to keep
> the plugin centred wrt its center point rather than its top-left.

Done.

[Jamie, 2011-09-07 01:40:52]

LGTM, but make sure Ken is happy with how it looks.