Trim content/common/DEPS to allow just the specific file needed.

Trim content/common/DEPS to allow just the specific file needed.

BUG=none
TEST=./tools/checkdeps/checkdeps.py says SUCCESS


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99590

[Ami GONE FROM CHROMIUM, 2011-08-31 20:02:33]

brettw: please review.
scherkus: FYI.

[brettw, 2011-08-31 20:11:50]

Can you clarify what the dependencies should be? Should content depend on media?
This seems reasonable to me since I would expect the content browser to be able
to play video, etc.

[Ami GONE FROM CHROMIUM, 2011-08-31 20:16:06]

The history is that previously lots of dank corners of the codebase depended
on media-internal details (not just public interfaces).  scherkus@ made a
pass to eliminate most/all of those a month or two ago.
Because we don't have a media/public/ vs. media/internal/ directory
separation, I prefer to eliminate DEPS on entire media subdirectories when
only one or two files need to be depended on, since those can be easier to
judge "public" vs. "internal".

Does that seem reasonable?

[brettw, 2011-08-31 20:20:53]

On Wed, Aug 31, 2011 at 1:15 PM, Ami Fischman <fischman@chromium.org> wrote:
> The history is that previously lots of dank corners of the codebase depended
> on media-internal details (not just public interfaces).  scherkus@ made a
> pass to eliminate most/all of those a month or two ago.
> Because we don't have a media/public/ vs. media/internal/ directory
> separation, I prefer to eliminate DEPS on entire media subdirectories when
> only one or two files need to be depended on, since those can be easier to
> judge "public" vs. "internal".
> Does that seem reasonable?

I guess the media team can do this how they want. But it seems weird
to me that this differentiation is done by the users of the API. Like
how can I tell as a reviewer when somebody adds a DEPS line for some
random header file in media whether that's appropriate or not?

Brett

[Ami GONE FROM CHROMIUM, 2011-08-31 20:34:17]

>
> I guess the media team can do this how they want.


FWIW, I'm on the media team :)


> Like how can I tell as a reviewer when somebody adds a DEPS line for some
> random header file in media whether that's appropriate or not?


I think there is no good way today.  My impression was that chromium didn't
have a good answer for this anywhere in the codebase other than certain
large rules like "content shouldn't depend on chrome".  Obviously that kind
of rule doesn't scale to every pair of directories in the codebase, and
offers the most value for well-known, large directories (like content &
chrome).  Sadly that puts the burden on OWNERS to police the codebase
periodically for sneaky DEPS.  I'd be happy to hear if there's something
better around.

[brettw, 2011-09-01 16:12:33]

LGTM

[commit-bot: I haz the power, 2011-09-04 04:43:38]

Change committed as 99590