Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 7821001: Add test for calling PostMessage during Init. Deflakify TestPostMessage. (Closed)

Created:
9 years, 3 months ago by dmichael (off chromium)
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add test for calling PostMessage during Init. Deflakify TestPostMessage. BUG=93260, 91768 TEST=This test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99442

Patch Set 1 #

Patch Set 2 : Use WaitForMessages in the non-main thread test #

Total comments: 1

Patch Set 3 : Made WaitForMessages only quit loop once #

Patch Set 4 : Turn down thread & message count to reduce flakiness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -54 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M ppapi/tests/test_post_message.h View 1 2 2 chunks +11 lines, -1 line 0 comments Download
M ppapi/tests/test_post_message.cc View 1 2 3 13 chunks +100 lines, -48 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmichael (off chromium)
FYI polina: PostMessage from DidCreate seems to work fine for trusted plugins (in or out ...
9 years, 3 months ago (2011-08-31 21:41:55 UTC) #1
polina
On 2011/08/31 21:41:55, dmichael wrote: > FYI polina: PostMessage from DidCreate seems to work fine ...
9 years, 3 months ago (2011-09-01 11:14:57 UTC) #2
brettw
LGTM
9 years, 3 months ago (2011-09-01 16:23:37 UTC) #3
Paweł Hajdan Jr.
Drive-by with a testing comment. I'd appreciate you _not_ committing this until the issue is ...
9 years, 3 months ago (2011-09-01 18:54:43 UTC) #4
dmichael (off chromium)
On 2011/09/01 18:54:43, Paweł Hajdan Jr. wrote: > Drive-by with a testing comment. I'd appreciate ...
9 years, 3 months ago (2011-09-01 19:00:27 UTC) #5
Paweł Hajdan Jr.
9 years, 3 months ago (2011-09-01 19:48:25 UTC) #6
Code I commented in the drive-by LGTM, thank you.

Powered by Google App Engine
This is Rietveld 408576698