Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1092)

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 7820004: extensions: Use Version ctor instead of calling GetVersionFromString(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add DCHECK Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_updater.cc
diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc
index 2bd4e6b22fbd3e3928e1fd7eded5256230d817fe..2959077b480019e3b5738c2524d684111a38d806 100644
--- a/chrome/browser/extensions/extension_updater.cc
+++ b/chrome/browser/extensions/extension_updater.cc
@@ -313,12 +313,11 @@ void ManifestFetchesBuilder::AddPendingExtension(
// Use a zero version to ensure that a pending extension will always
// be updated, and thus installed (assuming all extensions have
// non-zero versions).
- scoped_ptr<Version> version(
- Version::GetVersionFromString("0.0.0.0"));
+ Version version("0.0.0.0");
+ DCHECK(version.IsValid());
cpu_(ooo_6.6-7.5) 2011/09/01 02:11:32 that dcheck is checking a constant from the line b
- AddExtensionData(
- info.install_source(), id, *version,
- Extension::TYPE_UNKNOWN, info.update_url(), "");
+ AddExtensionData(info.install_source(), id, version,
+ Extension::TYPE_UNKNOWN, info.update_url(), "");
}
void ManifestFetchesBuilder::ReportStats() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698