net/http/http_response_info.cc - Issue 7819009: For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_response_info.cc

Issue 7819009: For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_response_info.cc

===================================================================

--- net/http/http_response_info.cc (revision 101367)

+++ net/http/http_response_info.cc (working copy)

@@ -151,8 +151,8 @@

return false;

}

if (flags & RESPONSE_INFO_HAS_CERT_STATUS) {

- int cert_status;

- if (!pickle.ReadInt(&iter, &cert_status))

+ CertStatus cert_status;

+ if (!pickle.ReadUInt32(&iter, &cert_status))

wtc 2011/09/21 23:54:25 I verified that this change does not affect how Pi

return false;

ssl_info.cert_status = cert_status;

}

@@ -244,7 +244,7 @@

if (ssl_info.is_valid()) {

ssl_info.cert->Persist(pickle);

- pickle->WriteInt(ssl_info.cert_status);

+ pickle->WriteUInt32(ssl_info.cert_status);

if (ssl_info.security_bits != -1)

pickle->WriteInt(ssl_info.security_bits);

if (ssl_info.connection_status != 0)

« net/base/cert_verify_result.cc ('K') | « net/http/http_network_transaction_unittest.cc ('k') | net/http/http_transaction_unittest.h » ('j') | no next file with comments »