Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: net/base/ssl_config_service.h

Issue 7819009: For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/ssl_config_service.h
===================================================================
--- net/base/ssl_config_service.h (revision 98481)
+++ net/base/ssl_config_service.h (working copy)
@@ -12,6 +12,7 @@
#include "base/memory/ref_counted.h"
#include "base/observer_list.h"
#include "base/string_piece.h"
+#include "net/base/cert_status_flags.h"
#include "net/base/net_export.h"
#include "net/base/x509_certificate.h"
@@ -27,12 +28,12 @@
// Returns true if |cert| is one of the certs in |allowed_bad_certs|.
// The expected cert status is written to |cert_status|. |*cert_status| can
// be NULL if user doesn't care about the cert status.
- bool IsAllowedBadCert(X509Certificate* cert, int* cert_status) const;
+ bool IsAllowedBadCert(X509Certificate* cert, CertStatus* cert_status) const;
// Same as above except works with DER encoded certificates instead
// of X509Certificate.
bool IsAllowedBadCert(const base::StringPiece& der_cert,
- int* cert_status) const;
+ CertStatus* cert_status) const;
bool rev_checking_enabled; // True if server certificate revocation
// checking is enabled.
@@ -77,7 +78,7 @@
~CertAndStatus();
std::string der_cert;
- int cert_status;
+ CertStatus cert_status;
};
// Add any known-bad SSL certificate (with its cert status) to

Powered by Google App Engine
This is Rietveld 408576698