content/browser/tab_contents/navigation_entry_unittest.cc - Issue 7819009: For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/tab_contents/navigation_entry_unittest.cc

Issue 7819009: For the SSL cert status, convert anonymous enum that gives bit values into a typedefed uint32. Th... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/tab_contents/navigation_entry.cc ('k') | content/browser/tab_contents/provisional_load_details.h » ('j') | net/base/cert_status_flags.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/tab_contents/navigation_entry_unittest.cc

===================================================================

--- content/browser/tab_contents/navigation_entry_unittest.cc (revision 98481)

+++ content/browser/tab_contents/navigation_entry_unittest.cc (working copy)

@@ -106,7 +106,7 @@

EXPECT_EQ(SECURITY_STYLE_UNKNOWN, entry1_.get()->ssl().security_style());

EXPECT_EQ(SECURITY_STYLE_UNKNOWN, entry2_.get()->ssl().security_style());

EXPECT_EQ(0, entry1_.get()->ssl().cert_id());

- EXPECT_EQ(0, entry1_.get()->ssl().cert_status());

+ EXPECT_EQ(net::CERT_STATUS_NO_ERROR, entry1_.get()->ssl().cert_status());

EXPECT_EQ(-1, entry1_.get()->ssl().security_bits());

EXPECT_FALSE(entry1_.get()->ssl().displayed_insecure_content());

EXPECT_FALSE(entry1_.get()->ssl().ran_insecure_content());

@@ -114,13 +114,14 @@

// Change from the defaults

entry2_.get()->ssl().set_security_style(SECURITY_STYLE_AUTHENTICATED);

entry2_.get()->ssl().set_cert_id(4);

- entry2_.get()->ssl().set_cert_status(1);

+ entry2_.get()->ssl().set_cert_status(net::CERT_STATUS_COMMON_NAME_INVALID);

entry2_.get()->ssl().set_security_bits(0);

entry2_.get()->ssl().set_displayed_insecure_content();

EXPECT_EQ(SECURITY_STYLE_AUTHENTICATED,

entry2_.get()->ssl().security_style());

EXPECT_EQ(4, entry2_.get()->ssl().cert_id());

- EXPECT_EQ(1, entry2_.get()->ssl().cert_status());

+ EXPECT_EQ(net::CERT_STATUS_COMMON_NAME_INVALID,

+ entry2_.get()->ssl().cert_status());

EXPECT_EQ(0, entry2_.get()->ssl().security_bits());

EXPECT_TRUE(entry2_.get()->ssl().displayed_insecure_content());