Print Preview: Populating print preview tab title as soon as it is known.

chrome/browser/ui/webui/print_preview_handler.cc

Index: chrome/browser/ui/webui/print_preview_handler.cc
diff --git a/chrome/browser/ui/webui/print_preview_handler.cc b/chrome/browser/ui/webui/print_preview_handler.cc
index 42597a5e30e44a4f877d48f3bd22df51c2e0138e..524412f4152e88281bb9c206b3094e1f8e515172 100644
--- a/chrome/browser/ui/webui/print_preview_handler.cc
+++ b/chrome/browser/ui/webui/print_preview_handler.cc
@@ -468,6 +468,8 @@ void PrintPreviewHandler::RegisterMessages() {
       NewCallback(this, &PrintPreviewHandler::HandleCancelPendingPrintRequest));
   web_ui_->RegisterMessageCallback("saveLastPrinter",
       NewCallback(this, &PrintPreviewHandler::HandleSaveLastPrinter));
+  web_ui_->RegisterMessageCallback("getInitiatorTabTitle",
+      NewCallback(this, &PrintPreviewHandler::HandleGetInitiatorTabTitle));
 }
 
 TabContentsWrapper* PrintPreviewHandler::preview_tab_wrapper() const {
@@ -765,6 +767,12 @@ void PrintPreviewHandler::ReportStats() {
                        manage_printers_dialog_request_count_);
 }
 
+void PrintPreviewHandler::HandleGetInitiatorTabTitle(
+    const ListValue* /*args*/) {

[dpapad, 2011/09/06 17:07:19]

Using this format for unused parameters according to the styleguide
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...).

[kmadhusu, 2011/09/06 18:19:32]

In this file, we don't follow that style in other function definitions.  It will
be better if this function signature is consistent with others.

[dpapad, 2011/09/06 21:27:51]

I changed all the method signatures (with unused parameters) to follow the
styleguide.

+  PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>(web_ui_);
+  print_preview_ui->SendInitiatorTabTitle();
+}
+
 void PrintPreviewHandler::ActivateInitiatorTabAndClosePreviewTab() {
   TabContentsWrapper* initiator_tab = GetInitiatorTab();
   if (initiator_tab) {