Index: chrome/browser/resources/print_preview/copies_settings.js |
diff --git a/chrome/browser/resources/print_preview/copies_settings.js b/chrome/browser/resources/print_preview/copies_settings.js |
index 3c48e45e271cd50787056e8a05a498e00e9954e9..53a1d4bab3603d59bb9fe0ceba5fd6ffbbd9515e 100644 |
--- a/chrome/browser/resources/print_preview/copies_settings.js |
+++ b/chrome/browser/resources/print_preview/copies_settings.js |
@@ -22,6 +22,13 @@ cr.define('print_preview', function() { |
this.collateCheckbox_ = $('collate'); |
this.hint_ = $('copies-hint'); |
this.twoSidedCheckbox_ = $('two-sided'); |
+ this.twoSidedOption_ = $('two-sided-div'); |
+ |
+ // Constant values matches printing::DuplexMode enum. Not using const |
+ // keyword because it is not allowed by JS strict mode. |
+ this.SIMPLEX = 0; |
+ this.LONG_EDGE = 1; |
+ this.UNKNOWN = -1; |
} |
cr.addSingletonGetter(CopiesSettings); |
@@ -56,15 +63,16 @@ cr.define('print_preview', function() { |
}, |
/** |
- * Gets the duplex mode for printing. |
+ * Gets the duplex mode information for printing. |
* @return {number} duplex mode. |
*/ |
- get duplexMode() { |
- // Constant values matches printing::DuplexMode enum. Not using const |
- // keyword because it is not allowed by JS strict mode. |
- var SIMPLEX = 0; |
- var LONG_EDGE = 1; |
- return !this.twoSidedCheckbox_.checked ? SIMPLEX : LONG_EDGE; |
+ get duplexMode() { |
+ if (this.twoSidedOption_.hidden) |
+ return this.UNKNOWN; |
+ else if (!this.twoSidedCheckbox_.checked) |
vandebo (ex-Chrome)
2011/09/07 21:55:57
nit: remove the ! and switch the bodies
kmadhusu
2011/09/07 23:21:56
Done.
|
+ return this.SIMPLEX; |
+ else |
+ return this.LONG_EDGE; |
}, |
/** |
@@ -158,7 +166,8 @@ cr.define('print_preview', function() { |
fadeInElement(this.copiesOption_); |
$('hr-before-copies').classList.add('invisible'); |
} |
- this.twoSidedCheckbox_.checked = e.printerCapabilities.setDuplexAsDefault; |
+ this.updateTwoSidedOption_( |
+ e.printerCapabilities.printerDefaultDuplexValue); |
}, |
/** |
@@ -190,6 +199,24 @@ cr.define('print_preview', function() { |
this.collateOption_.hidden); |
}, |
+ /* |
+ * Takes care of showing/hideing the two sided option and also updates the |
+ * default state of the checkbox. |
+ * @param {boolean} defaultDuplexValue Specifies the default duplex value. |
+ * @private |
+ */ |
+ updateTwoSidedOption_: function(defaultDuplexValue) { |
+ // On Windows, some printers don't specify their duplex values in the |
+ // printer schema. If the printer duplex value is UNKNOWN, hide the two |
+ // sided option in preview tab UI. |
+ // Ref bug: http://crbug.com/89204 |
+ this.twoSidedOption_.hidden = (defaultDuplexValue == this.UNKNOWN); |
+ this.twoSidedOption_.setAttribute('aria-hidden', |
+ this.twoSidedOption_.hidden); |
+ if (!this.twoSidedOption_.hidden) |
+ this.twoSidedCheckbox_.checked = defaultDuplexValue; |
+ }, |
+ |
/** |
* Updates the state of the increment/decrement buttons based on the current |
* |textfield_| value. |