PrintPreview: Added code to identify the printer default duplex value.

printing/printing_context_win.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/printing_context_win.h"
 
 #include <winspool.h>
 
 #include <algorithm>
 
@@ skipping 294 matching lines @@
 PrintingContext::Result PrintingContextWin::UpdatePrinterSettings(
     const DictionaryValue& job_settings,
     const PageRanges& ranges) {
   DCHECK(!in_print_job_);
 
   bool collate;
   bool color;
   bool landscape;
   bool print_to_pdf;
   int copies;
-  int duplex_mode;
+  DictionaryValue* duplex_info;
+  int printer_default_duplex_value;
+  int user_selected_duplex_value;
   string16 device_name;
 
   if (!job_settings.GetBoolean(kSettingLandscape, &landscape) ||
       !job_settings.GetBoolean(kSettingCollate, &collate) ||
       !job_settings.GetBoolean(kSettingColor, &color) ||
       !job_settings.GetBoolean(kSettingPrintToPDF, &print_to_pdf) ||
-      !job_settings.GetInteger(kSettingDuplexMode, &duplex_mode) ||
+      !job_settings.GetDictionary(kSettingDuplexModeInfo, &duplex_info) ||
+      !duplex_info->GetInteger(kPrinterDefaultDuplexValue,
+                               &printer_default_duplex_value) ||
+      !duplex_info->GetInteger(kUserSelectedDuplexValue,
+                               &user_selected_duplex_value) ||
       !job_settings.GetInteger(kSettingCopies, &copies) ||
       !job_settings.GetString(kSettingDeviceName, &device_name)) {
     return OnError();
   }
 
   bool print_to_cloud = job_settings.HasKey(printing::kSettingCloudPrintId);
 
   if (print_to_pdf || print_to_cloud) {
     // Pseudo printer: handle orientation and ranges only.
     settings_.SetOrientation(landscape);
@@ skipping 29 matching lines @@
   if (dev_mode == NULL) {
     buffer.reset();
     ClosePrinter(printer);
     return OnError();
   }
 
   dev_mode->dmColor = color ? DMCOLOR_COLOR : DMCOLOR_MONOCHROME;
   dev_mode->dmCopies = std::max(copies, 1);
   if (dev_mode->dmCopies > 1)  // do not change collate unless multiple copies
     dev_mode->dmCollate = collate ? DMCOLLATE_TRUE : DMCOLLATE_FALSE;
-  switch (duplex_mode) {
-    case LONG_EDGE:
-      dev_mode->dmDuplex = DMDUP_VERTICAL;
-      break;
-    case SHORT_EDGE:
-      dev_mode->dmDuplex = DMDUP_HORIZONTAL;
-      break;
-    default:  // simplex
-      dev_mode->dmDuplex = DMDUP_SIMPLEX;
-      break;
+  if (printer_default_duplex_value == printing::UNKNOWN) {
+    dev_mode->dmDuplex = user_selected_duplex_value ? DMDUP_HORIZONTAL :

[vandebo (ex-Chrome), 2011/09/02 18:12:50]

This assumes that SIMPLEX is "false."  Instead, you could fix up
dev_mode->dmDuplux after the switch, i.e. if vertical isn't supported, change it
to horizontal.

A comment and reference to a bug number wouldn't hurt.

[kmadhusu, 2011/09/03 00:34:00]

As we discussed, I reverted the printing context code changes. JS will now
return SHORT_EDGE if the duplex value is unknown. Added a comment and bug
reference in js.

+                                                      DMDUP_SIMPLEX;
+  } else {
+    switch (user_selected_duplex_value) {
+      case LONG_EDGE:
+        dev_mode->dmDuplex = DMDUP_VERTICAL;
+        break;
+      case SHORT_EDGE:
+        dev_mode->dmDuplex = DMDUP_HORIZONTAL;
+        break;
+      default:  // simplex
+        dev_mode->dmDuplex = DMDUP_SIMPLEX;
+        break;
+    }
   }
   dev_mode->dmOrientation = landscape ? DMORIENT_LANDSCAPE : DMORIENT_PORTRAIT;
 
   // Update data using DocumentProperties.
   if (DocumentProperties(NULL, printer, device_name_wide, dev_mode, dev_mode,
                          DM_IN_BUFFER | DM_OUT_BUFFER) != IDOK) {
     ClosePrinter(printer);
     return OnError();
   }
 
@@ skipping 364 matching lines @@
   if (buf_size) {
     buffer->reset(new uint8[buf_size]);
     memset(buffer->get(), 0, buf_size);
     if (!GetPrinter(printer, level, buffer->get(), buf_size, &buf_size)) {
       buffer->reset();
     }
   }
 }
 
 }  // namespace printing