Convert some constants declared as anonymous enums into static consts so they have types. This d...

ipc/file_descriptor_set_posix.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ipc/file_descriptor_set_posix.h"
 
 #include <sys/types.h>
 #include <sys/stat.h>
 
 #include "base/eintr_wrapper.h"
@@ skipping 18 matching lines @@
   // kernel resources.
   for (unsigned i = consumed_descriptor_highwater_;
        i < descriptors_.size(); ++i) {
     if (descriptors_[i].auto_close)
       if (HANDLE_EINTR(close(descriptors_[i].fd)) < 0)
         PLOG(ERROR) << "close";
   }
 }
 
 bool FileDescriptorSet::Add(int fd) {
-  if (descriptors_.size() == MAX_DESCRIPTORS_PER_MESSAGE)
+  if (descriptors_.size() == kMaxDescriptorsPerMessage)
     return false;
 
   struct base::FileDescriptor sd;
   sd.fd = fd;
   sd.auto_close = false;
   descriptors_.push_back(sd);
   return true;
 }
 
 bool FileDescriptorSet::AddAndAutoClose(int fd) {
-  if (descriptors_.size() == MAX_DESCRIPTORS_PER_MESSAGE)
+  if (descriptors_.size() == kMaxDescriptorsPerMessage)
     return false;
 
   struct base::FileDescriptor sd;
   sd.fd = fd;
   sd.auto_close = true;
   descriptors_.push_back(sd);
-  DCHECK(descriptors_.size() <= MAX_DESCRIPTORS_PER_MESSAGE);
+  DCHECK(descriptors_.size() <= kMaxDescriptorsPerMessage);
   return true;
 }
 
 int FileDescriptorSet::GetDescriptorAt(unsigned index) const {
   if (index >= descriptors_.size())
     return -1;
 
   // We should always walk the descriptors in order, so it's reasonable to
   // enforce this. Consider the case where a compromised renderer sends us
   // the following message:
@@ skipping 47 matching lines @@
        i = descriptors_.begin(); i != descriptors_.end(); ++i) {
     if (i->auto_close)
       if (HANDLE_EINTR(close(i->fd)) < 0)
         PLOG(ERROR) << "close";
   }
   descriptors_.clear();
   consumed_descriptor_highwater_ = 0;
 }
 
 void FileDescriptorSet::SetDescriptors(const int* buffer, unsigned count) {
-  DCHECK_LE(count, MAX_DESCRIPTORS_PER_MESSAGE);
+  DCHECK(count <= kMaxDescriptorsPerMessage);
   DCHECK_EQ(descriptors_.size(), 0u);
   DCHECK_EQ(consumed_descriptor_highwater_, 0u);
 
   descriptors_.reserve(count);
   for (unsigned i = 0; i < count; ++i) {
     struct base::FileDescriptor sd;
     sd.fd = buffer[i];
     sd.auto_close = true;
     descriptors_.push_back(sd);
   }
 }