Issue 7813: Call GdiAlphaBlend directly instead of the AlphaBlend wrapper in msimg32.dll....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7813: Call GdiAlphaBlend directly instead of the AlphaBlend wrapper in msimg32.dll.... (Closed)

Created:
12 years, 2 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel, brett

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Call GdiAlphaBlend directly instead of the AlphaBlend wrapper in msimg32.dll. The wrapper does a few additional santity checks, which I presume GdiAlphaBlend will have to handle anyway. This means we don't depend on msimg32.dll anymore. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=3656

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -22 lines)			Patch
M	base/clipboard_win.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	base/gfx/bitmap_platform_device_win.cc	View	1 chunk	+12 lines, -11 lines	0 comments	Download
M	base/gfx/vector_device.cc	View	1 chunk	+7 lines, -7 lines	0 comments	Download
	chrome/app/chrome.dll.deps	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

12 years, 2 months ago (2008-10-21 13:48:17 UTC) #1

Not a huge deal, I'm hoping GdiAlphaBlend will catch any failures that
AlphaBlend did.  It calls pretty much directly into the kernel, so I imagine it
does plenty of error checking there.

Expand Messages | Collapse Messages