Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 7812019: MIPS: small test-case fix for chaining of fixup position. (Closed)

Created:
9 years, 3 months ago by Paul Lind
Modified:
9 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

MIPS: small test-case fix for chaining of fixup position. Add nops to the branch-delay slots of the 'beq' and 'bne' instructions used in the test-case. Having a branch instruction in the branch-delay-slot of another branch is undefined on mips. In regular code we avoid this by using the Branch() macro-instruction which fills the branch-delay-slot with nop() automatically, unless the programmer asks to use it (via USE_BRANCH_DELAY). There is more info about branch-delay-slots on this page, and in the ISA reference also on the page: https://github.com/paul99/v8m-rb/wiki/MIPS-instruction-set-and-v8 BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9079

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/cctest/test-assembler-mips.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
9 years, 3 months ago (2011-08-31 03:17:51 UTC) #1
Sven Panne
9 years, 3 months ago (2011-08-31 09:17:39 UTC) #2
LGTM. Note that this patch is not really necessary, because we never execute the
machine code in these kind of tests, we do not even create a Code object. We
just need a forward reference to a label in the first instruction and another
forward reference later to test bind's behavior for this edge case. Anyway, I'll
land it to improve the code's esthetics... ;-)

Powered by Google App Engine
This is Rietveld 408576698