Issue 7812011: Tighten conditions for when a URL is a search result, and move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7812011: Tighten conditions for when a URL is a search result, and move (Closed)

Created:
9 years, 3 months ago by tburkard

Modified:
9 years, 3 months ago

Reviewers:
dominich, ziga

CC:
chromium-reviews, tburkard+watch_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Tighten conditions for when a URL is a search result, and move it to a different class. R=ziga, dominich Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98895

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -6 lines)			Patch
M	chrome/browser/prerender/prerender_manager.cc	View	1 2 3	2 chunks	+1 line, -5 lines	0 comments	Download
M	chrome/browser/prerender/prerender_util.h	View	1 2 3	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_util.cc	View	1 2 3	2 chunks	+10 lines, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_util_unittest.cc	View	1 2 3	2 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dominich

9 years, 3 months ago (2011-08-30 23:43:32 UTC) #3

LGTM

http://codereview.chromium.org/7812011/diff/2003/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_util.cc (right):

http://codereview.chromium.org/7812011/diff/2003/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_util.cc:68: return (url.path().empty() ||
nit: can the URL path be empty? I thought it was always at least '/'.

http://codereview.chromium.org/7812011/diff/2003/chrome/browser/prerender/pre...
File chrome/browser/prerender/prerender_util_unittest.cc (right):

http://codereview.chromium.org/7812011/diff/2003/chrome/browser/prerender/pre...
chrome/browser/prerender/prerender_util_unittest.cc:51: // Ensure that we detect
Gooble search result URLs correctly.
hehe .. Gooble.

Expand Messages | Collapse Messages