base/base.gypi - Issue 7812009: Base: Switch base_i18n to be a separate dll (component build)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base.gypi

Issue 7812009: Base: Switch base_i18n to be a separate dll (component build) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base.gypi

===================================================================

--- base/base.gypi (revision 97736)

+++ base/base.gypi (working copy)

@@ -621,9 +621,6 @@

'defines': [

'<@(nacl_win64_defines)',

- 'sources': [

- 'i18n/icu_util_nacl_win64.cc',

- ],

'configurations': {

'Common_Base': {

'msvs_target_platform': 'x64',

@@ -639,7 +636,7 @@

{

'target_name': 'base_i18n_nacl_win64',

- 'type': 'static_library',

+ 'type': '<(component)',

# TODO(gregoryd): direct_dependent_settings should be shared with the

# 32-bit target, but it doesn't work due to a bug in gyp

'direct_dependent_settings': {

@@ -649,6 +646,7 @@

'defines': [

'<@(nacl_win64_defines)',

+ 'BASE_I18N_IMPLEMENTATION',

'include_dirs': [

'..',

« no previous file with comments | « base/base.gyp ('k') | base/i18n/base_i18n_export.h » ('j') | no next file with comments »