Issue 7812009: Base: Switch base_i18n to be a separate dll (component build)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7812009: Base: Switch base_i18n to be a separate dll (component build) (Closed)

Created:
9 years, 3 months ago by rvargas (doing something else)

Modified:
9 years, 3 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Base: Switch base_i18n to be a separate dll (component build) BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99057

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -75 lines)			Patch
M	base/base.gyp	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	base/base.gypi	View	1	3 chunks	+2 lines, -4 lines	0 comments	Download
A	base/i18n/base_i18n_export.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
M	base/i18n/bidi_line_iterator.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	base/i18n/break_iterator.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	base/i18n/case_conversion.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	base/i18n/char_iterator.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	base/i18n/file_util_icu.h	View		3 chunks	+8 lines, -5 lines	0 comments	Download
M	base/i18n/icu_encoding_detection.h	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	base/i18n/icu_string_conversions.h	View		3 chunks	+25 lines, -24 lines	0 comments	Download
M	base/i18n/icu_util.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	base/i18n/number_formatting.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	base/i18n/rtl.h	View		5 chunks	+20 lines, -17 lines	0 comments	Download
M	base/i18n/time_formatting.h	View		2 chunks	+12 lines, -10 lines	0 comments	Download
M	ui/ui_unittests.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM !