Remove static initializers in autofill_country.cc.

Remove static initializers in autofill_country.cc.

BUG=None
TEST=nm out/Debug/chrome | grep _GLOBAL__I doesn't list autofill_country.cc

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98986

[Evan Martin, 2011-08-30 22:22:52]

I wonder if it's worth trying to push this further -- like using StringPiece or
just a char* for the CountryData.

[Peter Kasting, 2011-08-30 22:23:56]

On 2011/08/30 22:22:52, Evan Martin wrote:
> I wonder if it's worth trying to push this further -- like using StringPiece
or
> just a char* for the CountryData.

I had the same thought, especially since a number of the places that use the
country code in this file call .c_str() on it anyway.

[tony, 2011-08-30 22:39:19]

Turns out we don't need the country code at all in the value part of the map.

[Peter Kasting, 2011-08-30 22:55:52]

http://codereview.chromium.org/7812008/diff/2003/chrome/browser/autofill/auto...
File chrome/browser/autofill/autofill_country.cc (right):

http://codereview.chromium.org/7812008/diff/2003/chrome/browser/autofill/auto...
chrome/browser/autofill/autofill_country.cc:42: int postal_code_label_id;
Nit: If we nested the structs:

struct CountryDataInitializer {
  char country_code[3];
  CountryData country_data;
};

...then in addition to not repeating the members, we'd save having to construct
a temporary CountryData struct in the loop in the constructor.

[tony, 2011-08-30 23:11:28]

http://codereview.chromium.org/7812008/diff/2003/chrome/browser/autofill/auto...
File chrome/browser/autofill/autofill_country.cc (right):

http://codereview.chromium.org/7812008/diff/2003/chrome/browser/autofill/auto...
chrome/browser/autofill/autofill_country.cc:42: int postal_code_label_id;
On 2011/08/30 22:55:52, Peter Kasting wrote:
> Nit: If we nested the structs:
> 
> struct CountryDataInitializer {
>   char country_code[3];
>   CountryData country_data;
> };
> 
> ...then in addition to not repeating the members, we'd save having to
construct
> a temporary CountryData struct in the loop in the constructor.

Good idea!  Done.

[Ilya Sherman, 2011-08-30 23:21:11]

LGTM.  Thanks for the fix!