Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 7812003: Disable ppapi_ppb_url_request_info_browser_test for now (Closed)

Created:
9 years, 3 months ago by Roland McGrath
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Disable ppapi_ppb_url_request_info_browser_test for now This test is breaking for the NaCl buildbots. Disable it until Polina has time to investigate. BUG= http://code.google.com/p/chromium/issues/detail?id=94790 TEST= none R=polina@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98918

Patch Set 1 #

Total comments: 1

Patch Set 2 : added TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ppapi/native_client/tests/ppapi_browser/ppb_url_request_info/nacl.scons View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Roland McGrath
9 years, 3 months ago (2011-08-30 20:43:23 UTC) #1
polina
LGTM Thanks! http://codereview.chromium.org/7812003/diff/1/ppapi/native_client/tests/ppapi_browser/ppb_url_request_info/nacl.scons File ppapi/native_client/tests/ppapi_browser/ppb_url_request_info/nacl.scons (right): http://codereview.chromium.org/7812003/diff/1/ppapi/native_client/tests/ppapi_browser/ppb_url_request_info/nacl.scons#newcode39 ppapi/native_client/tests/ppapi_browser/ppb_url_request_info/nacl.scons:39: is_broken=env.PPAPIBrowserTesterIsBroken() or True) add a TODO with ...
9 years, 3 months ago (2011-08-30 21:52:12 UTC) #2
Roland McGrath
Need an OWNERS LGTM, please.
9 years, 3 months ago (2011-08-30 21:55:41 UTC) #3
sehr (please use chromium)
LGTM.
9 years, 3 months ago (2011-08-30 22:22:36 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-08-31 02:58:34 UTC) #5
Change committed as 98918

Powered by Google App Engine
This is Rietveld 408576698