Issue 7812001: Fix "2nd print fails on Mac sometimes" bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7812001: Fix "2nd print fails on Mac sometimes" bug. (Closed)

Created:
9 years, 3 months ago by vandebo (ex-Chrome)

Modified:
9 years, 3 months ago

Reviewers:
commit-bot: I haz the power, kmadhusu

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix "2nd print fails on Mac sometimes" bug. Mac does not accept printer ids with special characters (space, dot, etc), so when we saved the printer used by name instead of id, subsequent prints would fail. BUG=91895 TEST=Print twice to a printer with a special character, like space in the name. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98925

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	chrome/browser/resources/print_preview/print_preview.js	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 98925

Expand Messages | Collapse Messages